Page MenuHomePhabricator

Special:ListUsers does not take external groups into account
Closed, ResolvedPublic


Author: mati

Proposed patch that fixes the problem

The function formatRow in includes/specials/SpecialListusers.php gets and prints a list of groups the user is in. The function does not take into account that some groups might not show up in the database if they have been added using the UserEffectiveGroups hook. If the user is in no local groups or in just one local group, the groups from the external source are not shown.

Attached is a proposed patch which fixes the problem. It also simplifies the code somewhat, I think there are some unnecessary checks there.

Version: 1.16.x
Severity: enhancement




Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:09 PM
bzimport set Reference to bz24987.
bzimport added a subscriber: Unknown Object (MLST).