Page MenuHomePhabricator
Create Task
Maniphest T269873

Regression: Page Previews removes titles of all wikilinks, not just articles'
Closed, ResolvedPublic
Actions

Description

(Via @SerDIDG)
Recently Page Previews has started removing the title attribute of all wikilinks, not just those of article namespace pages. This has broken the work of several gadgets in Russian Wikipedia, including the highly popular gadget showing user flags and the gadget handling featured article links. They rely on link titles in their workings.

Details

SubjectRepoBranchLines +/-
Revert "Remove title attributes at init"mediawiki/extensions/Popupswmf/1.36.0-wmf.21+178 -11
Revert "Remove title attributes at init"mediawiki/extensions/Popupsmaster+178 -11
Customize query in gerrit

Related Objects

Event Timeline

Jack_who_built_the_house created this task.Dec 10 2020, 5:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2020, 5:36 PM
IKhitron subscribed.Dec 10 2020, 5:39 PM
Jdlrobson mentioned this in T269297: Performance optimization for popup rendering: Remove title attributes at init.Dec 10 2020, 5:42 PM
Dmidek subscribed.Dec 10 2020, 5:44 PM
Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).Dec 10 2020, 6:17 PM
Jdlrobson moved this task from Needs Analysis to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Dec 10 2020, 10:36 PM
Ammarpad merged a task: T269889: HTML 'title' attributes no longer generated on wikilinks.Dec 11 2020, 2:08 AM
Ammarpad added a subscriber: matmarex.
Aqetz subscribed.Dec 11 2020, 6:02 AM
MBH subscribed.Dec 11 2020, 10:42 AM
gerritbot added a comment.Dec 11 2020, 4:30 PM

Change 648270 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Popups@master] Revert "Remove title attributes at init"

https://gerrit.wikimedia.org/r/648270

gerritbot added a project: Patch-For-Review.Dec 11 2020, 4:30 PM
gerritbot added a comment.Dec 11 2020, 6:33 PM

Change 648270 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Revert "Remove title attributes at init"

https://gerrit.wikimedia.org/r/648270

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 11 2020, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 11 2020, 7:10 PM
Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Dec 11 2020, 7:11 PM
Jdlrobson subscribed.

I guess this needs backporting. Anyone available to do this Monday?

gerritbot added a comment.Dec 14 2020, 4:32 PM

Change 649408 had a related patch set uploaded (by Jdlrobson; owner: Bartosz Dziewoński):
[mediawiki/extensions/Popups@wmf/1.36.0-wmf.21] Revert "Remove title attributes at init"

https://gerrit.wikimedia.org/r/649408

gerritbot added a project: Patch-For-Review.Dec 14 2020, 4:32 PM
gerritbot added a comment.Dec 14 2020, 7:19 PM

Change 649408 merged by jenkins-bot:
[mediawiki/extensions/Popups@wmf/1.36.0-wmf.21] Revert "Remove title attributes at init"

https://gerrit.wikimedia.org/r/649408

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.21; 2020-12-08); removed MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 14 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 14 2020, 8:10 PM
matmarex added a comment.Dec 14 2020, 9:00 PM

Thanks @Jdlrobson!

Jdlrobson closed this task as Resolved.Dec 14 2020, 9:08 PM
Jdlrobson claimed this task.
Jdlrobson added a subscriber: • nray.

Thanks @nray for the deploy.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL