Mobile menus need nojs fallback
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Isarra
	Dec 10 2020, 9:24 PM

Description

Mobile menus currently only render with js. Given unusually high mobile breakpoints, this is particularly not good.

Details

	Subject	Repo	Branch	Lines +/-
	Implement nojs menus for mobile	mediawiki/skins/GreyStuff	master	+65 -0

Customize query in gerrit

Related Objects

Mentioned In: T278054: Dropdown toggles should be accessible to keyboard navigation and the like

Event Timeline

Isarra created this task.Dec 10 2020, 9:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2020, 9:24 PM

FYI In Vector and Minerva we use a checkbox hack for the menus. We've been meaning to consolidate the associated CSS code as a core module.

Take a look at their code and let me know if something in core based on them would help this.

In T269891#6684977, @Jdlrobson wrote:

FYI In Vector and Minerva we use a checkbox hack for the menus. We've been meaning to consolidate the associated CSS code as a core module.

I thought the purpose of the checkboxes was so there'd be accessible toggles for folks not using normal input (mouse/touch), and the like, js or otherwise? Unfortunately I don't really understand it, so I have a bunch of skins here that just don't support this use case I can't figure out how to replicate to begin with... is there, like, some actual documentation/guidelines on this somewhere?

Change 673645 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/GreyStuff@master] Implement nojs menus for mobile

https://gerrit.wikimedia.org/r/673645

gerritbot added a project: Patch-For-Review.Mar 20 2021, 2:20 AM

Change 673645 merged by jenkins-bot:
[mediawiki/skins/GreyStuff@master] Implement nojs menus for mobile

https://gerrit.wikimedia.org/r/673645

Maintenance_bot removed a project: Patch-For-Review.Mar 20 2021, 8:10 PM

Isarra closed this task as Resolved.Mar 21 2021, 4:55 PM

Isarra claimed this task.

Isarra mentioned this in T278054: Dropdown toggles should be accessible to keyboard navigation and the like.Mar 21 2021, 4:59 PM