Page MenuHomePhabricator
Create Task
Maniphest T269952

Split up apisandbox.js
Open, Needs TriagePublic
Actions

Description

The apisandbox.js file declares a whole bunch of classes that would be better off in their own files imported via package files

Details

Show related patches Customize query in gerrit

Event Timeline

DannyS712 created this task.Dec 11 2020, 6:27 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 11 2020, 6:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Dec 11 2020, 6:28 PM

Change 648273 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split OptionalParamWidget to separate file

https://gerrit.wikimedia.org/r/648273

gerritbot added a project: Patch-For-Review.Dec 11 2020, 6:28 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Dec 11 2020, 6:34 PM
Jdlrobson awarded a token.Dec 11 2020, 7:14 PM
gerritbot added a comment.Dec 14 2020, 11:45 PM

Change 648273 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split OptionalParamWidget to separate file

https://gerrit.wikimedia.org/r/648273

gerritbot added a comment.Dec 14 2020, 11:57 PM

Change 649397 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split UploadParamWidget to separate file

https://gerrit.wikimedia.org/r/649397

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 15 2020, 12:02 AM
gerritbot added a comment.Dec 15 2020, 8:53 PM

Change 649690 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - inject shouldSuppressErrors into apiCheckValid

https://gerrit.wikimedia.org/r/649690

gerritbot added a comment.Dec 15 2020, 10:52 PM

Change 649690 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - inject shouldSuppressErrors into apiCheckValid

https://gerrit.wikimedia.org/r/649690

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 15 2020, 11:00 PM
gerritbot added a comment.Dec 16 2020, 1:15 AM

Change 649397 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split UploadParamWidget to separate file

https://gerrit.wikimedia.org/r/649397

Maintenance_bot removed a project: Patch-For-Review.Dec 16 2020, 2:10 AM
gerritbot added a comment.Dec 16 2020, 5:31 PM

Change 649907 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - rename UploadParamWidget to UploadSelectFileParamWidget

https://gerrit.wikimedia.org/r/649907

gerritbot added a project: Patch-For-Review.Dec 16 2020, 5:31 PM
gerritbot added a comment.Dec 16 2020, 7:41 PM

Change 649907 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - rename UploadParamWidget to UploadSelectFileParamWidget

https://gerrit.wikimedia.org/r/649907

gerritbot added a comment.Dec 17 2020, 7:11 AM

Change 649917 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Split up a bunch more apisandbox classes

https://gerrit.wikimedia.org/r/649917

SarthakKundra subscribed.Feb 8 2021, 12:33 PM

Hi @DannyS712 . Can I work on this as well? Asking because you've already assigned yourself and submitted a bunch of patches.

DannyS712 added a comment.Feb 8 2021, 1:42 PM
In T269952#6810771, @SarthakKundra wrote:

Hi @DannyS712 . Can I work on this as well? Asking because you've already assigned yourself and submitted a bunch of patches.

I'm already working on this, sorry

gerritbot added a comment.Feb 11 2021, 2:17 AM

Change 663083 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split BooleanToggleSwitchParamWidget to separate file

https://gerrit.wikimedia.org/r/663083

gerritbot added a comment.Feb 11 2021, 2:30 AM

Change 663084 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split ParamLabelWidget to separate file

https://gerrit.wikimedia.org/r/663084

gerritbot added a comment.Feb 16 2021, 11:52 PM

Change 664651 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split DateTimeParamWidget to separate file

https://gerrit.wikimedia.org/r/664651

gerritbot added a comment.Feb 17 2021, 12:22 AM

Change 663083 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split BooleanToggleSwitchParamWidget to separate file

https://gerrit.wikimedia.org/r/663083

gerritbot added a comment.Feb 17 2021, 12:22 AM

Change 663084 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split ParamLabelWidget to separate file

https://gerrit.wikimedia.org/r/663084

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.32; 2021-02-23); removed MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Feb 17 2021, 1:00 AM
gerritbot added a comment.Feb 26 2021, 7:10 PM

Change 664651 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split DateTimeParamWidget to separate file

https://gerrit.wikimedia.org/r/664651

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.33; 2021-03-02); removed MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 26 2021, 8:00 PM
gerritbot added a comment.Feb 26 2021, 8:04 PM

Change 667248 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - add LimitParamWidget to separate file

https://gerrit.wikimedia.org/r/667248

gerritbot added a comment.Feb 26 2021, 8:45 PM

Change 667252 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split PasswordParamWidget to separate file

https://gerrit.wikimedia.org/r/667252

gerritbot added a comment.Mar 19 2021, 8:57 PM

Change 667248 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split LimitParamWidget to separate file

https://gerrit.wikimedia.org/r/667248

gerritbot added a comment.Mar 19 2021, 9:00 PM

Change 667252 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split PasswordParamWidget to separate file

https://gerrit.wikimedia.org/r/667252

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.36; 2021-03-23); removed MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 19 2021, 9:00 PM
gerritbot added a comment.Mar 21 2021, 5:12 PM

Change 673787 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split IntegerParamWidget to separate file

https://gerrit.wikimedia.org/r/673787

DannyS712 added a comment.EditedMar 22 2021, 11:53 PM

Note to self for later
UtilMixin.setParamInfo
override for extra behavior, and call UtilMixin.prototype.setParamInfo.call( this, paramInfo ) for the parent behavior too
eg search for GroupWidget.prototype in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/dcc67bd33a77ec9a67bc56fd0e391f496a70348b/resources/lib/ooui/oojs-ui-core.js
Will do once the IntegerParamWidget patch merges

gerritbot added a comment.Mar 24 2021, 7:03 PM

Change 673787 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split IntegerParamWidget to separate file

https://gerrit.wikimedia.org/r/673787

gerritbot added a comment.Mar 24 2021, 7:45 PM

Change 674667 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] apisandbox.js - simplify some logic in createWidgetForParameter

https://gerrit.wikimedia.org/r/674667

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.37; 2021-03-30); removed MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 24 2021, 8:00 PM
gerritbot added a comment.Mar 25 2021, 3:24 AM

Change 674677 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] apisandbox.js - add UtilMixin.setParamInfo

https://gerrit.wikimedia.org/r/674677

gerritbot added a comment.Mar 25 2021, 7:50 PM

Change 674667 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - simplify some logic for widget creation

https://gerrit.wikimedia.org/r/674667

gerritbot added a comment.Mar 28 2021, 5:16 PM

Change 675295 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] apisandbox.js - split TokenParamWidget to separate file

https://gerrit.wikimedia.org/r/675295

DannyS712 removed DannyS712 as the assignee of this task.Oct 5 2023, 9:42 PM

I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL