Page MenuHomePhabricator

Split up apisandbox.js
Open, Needs TriagePublic

Description

The apisandbox.js file declares a whole bunch of classes that would be better off in their own files imported via package files

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 648273 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split OptionalParamWidget to separate file

https://gerrit.wikimedia.org/r/648273

Change 648273 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split OptionalParamWidget to separate file

https://gerrit.wikimedia.org/r/648273

Change 649397 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split UploadParamWidget to separate file

https://gerrit.wikimedia.org/r/649397

Change 649690 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - inject shouldSuppressErrors into apiCheckValid

https://gerrit.wikimedia.org/r/649690

Change 649690 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - inject shouldSuppressErrors into apiCheckValid

https://gerrit.wikimedia.org/r/649690

Change 649397 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split UploadParamWidget to separate file

https://gerrit.wikimedia.org/r/649397

Change 649907 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - rename UploadParamWidget to UploadSelectFileParamWidget

https://gerrit.wikimedia.org/r/649907

Change 649907 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - rename UploadParamWidget to UploadSelectFileParamWidget

https://gerrit.wikimedia.org/r/649907

Change 649917 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Split up a bunch more apisandbox classes

https://gerrit.wikimedia.org/r/649917

Hi @DannyS712 . Can I work on this as well? Asking because you've already assigned yourself and submitted a bunch of patches.

Hi @DannyS712 . Can I work on this as well? Asking because you've already assigned yourself and submitted a bunch of patches.

I'm already working on this, sorry

Change 663083 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split BooleanToggleSwitchParamWidget to separate file

https://gerrit.wikimedia.org/r/663083

Change 663084 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split ParamLabelWidget to separate file

https://gerrit.wikimedia.org/r/663084

Change 664651 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split DateTimeParamWidget to separate file

https://gerrit.wikimedia.org/r/664651

Change 663083 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split BooleanToggleSwitchParamWidget to separate file

https://gerrit.wikimedia.org/r/663083

Change 663084 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split ParamLabelWidget to separate file

https://gerrit.wikimedia.org/r/663084

Change 664651 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split DateTimeParamWidget to separate file

https://gerrit.wikimedia.org/r/664651

Change 667248 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - add LimitParamWidget to separate file

https://gerrit.wikimedia.org/r/667248

Change 667252 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split PasswordParamWidget to separate file

https://gerrit.wikimedia.org/r/667252

Change 667248 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split LimitParamWidget to separate file

https://gerrit.wikimedia.org/r/667248

Change 667252 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split PasswordParamWidget to separate file

https://gerrit.wikimedia.org/r/667252

Change 673787 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] apisandbox.js - split IntegerParamWidget to separate file

https://gerrit.wikimedia.org/r/673787

Note to self for later
UtilMixin.setParamInfo
override for extra behavior, and call UtilMixin.prototype.setParamInfo.call( this, paramInfo ) for the parent behavior too
eg search for GroupWidget.prototype in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/dcc67bd33a77ec9a67bc56fd0e391f496a70348b/resources/lib/ooui/oojs-ui-core.js
Will do once the IntegerParamWidget patch merges

Change 673787 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - split IntegerParamWidget to separate file

https://gerrit.wikimedia.org/r/673787

Change 674667 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] apisandbox.js - simplify some logic in createWidgetForParameter

https://gerrit.wikimedia.org/r/674667

Change 674677 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] apisandbox.js - add UtilMixin.setParamInfo

https://gerrit.wikimedia.org/r/674677

Change 674667 merged by jenkins-bot:
[mediawiki/core@master] apisandbox.js - simplify some logic for widget creation

https://gerrit.wikimedia.org/r/674667

Change 675295 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] apisandbox.js - split TokenParamWidget to separate file

https://gerrit.wikimedia.org/r/675295