Page MenuHomePhabricator

Schema change for timestamp field of uploadstash
Closed, ResolvedPublic

Description

(Part of T42626: Standardise type of timestamp database fields (MySQL) and T230428: Migrate tables.sql to abstract schema)

  1. ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/649102/2/maintenance/archives/patch-uploadstash-us_timestamp.sql
  2. Where to run those changes: all.dblist
  3. When to run those changes: At any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: Tested in beta cluster.
  6. if the data should be made available on the labs replicas and/or dumps: Yes, data in this table is public

Turning it from VARBINARY(14) to BINARY(14)

  • s1
  • s2
  • s3
  • s4
  • s5
  • s6
  • s7
  • s8
  • wikitech
  • labtestwiki

Event Timeline

LSobanski triaged this task as Medium priority.Dec 14 2020, 10:22 AM
LSobanski moved this task from Triage to Ready on the DBA board.
LSobanski added a subscriber: LSobanski.

Altered db2114 on s6, leaving it for a few hours to make sure nothing breaks (even if the table is empty there)

# for i in frwiki jawiki ruwiki; do mysql.py -hdb2114 $i -e "show create table uploadstash\G" | grep us_timestamp ; done
  `us_timestamp` binary(14) NOT NULL,
  KEY `us_timestamp` (`us_timestamp`)
  `us_timestamp` binary(14) NOT NULL,
  KEY `us_timestamp` (`us_timestamp`)
  `us_timestamp` binary(14) NOT NULL,
  KEY `us_timestamp` (`us_timestamp`)

Mentioned in SAL (#wikimedia-operations) [2021-01-27T05:50:03Z] <marostegui> Deploy schema change on s3 T270055

Marostegui updated the task description. (Show Details)

All done