Page MenuHomePhabricator
Create Task
Maniphest T270056

LDAPAuthentication2::authenticate() should populate $id if the user already exists
Closed, ResolvedPublic
Actions

Description

Otherwise PluggableAuth thinks it has a new user each time and hooks like PluggableAuthPopulateGroups won't be called.

Details

SubjectRepoBranchLines +/-
Ensure that $id is populated for all existing usersmediawiki/extensions/LDAPAuthentication2REL1_31+7 -3
Ensure that $id is populated for all existing usersmediawiki/extensions/LDAPAuthentication2REL1_35+7 -3
Ensure that $id is populated for all existing usersmediawiki/extensions/LDAPAuthentication2master+7 -3
Populate $id if we canmediawiki/extensions/LDAPAuthentication2master+5 -0
Populate $id if we canmediawiki/extensions/LDAPAuthentication2REL1_31+5 -0
Populate $id if we canmediawiki/extensions/LDAPAuthentication2REL1_35+5 -0
Customize query in gerrit

Related Objects

Event Timeline

MarkAHershberger created this task.Dec 13 2020, 8:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2020, 8:26 PM
gerritbot added a comment.Dec 13 2020, 8:34 PM

Change 649109 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/extensions/LDAPAuthentication2@master] Populate $id if we can

https://gerrit.wikimedia.org/r/649109

gerritbot added a project: Patch-For-Review.Dec 13 2020, 8:34 PM
gerritbot added a comment.Dec 14 2020, 7:24 AM

Change 648280 had a related patch set uploaded (by Robert Vogel; owner: MarkAHershberger):
[mediawiki/extensions/LDAPAuthentication2@REL1_31] Populate $id if we can

https://gerrit.wikimedia.org/r/648280

gerritbot added a comment.Dec 14 2020, 7:24 AM

Change 648281 had a related patch set uploaded (by Robert Vogel; owner: MarkAHershberger):
[mediawiki/extensions/LDAPAuthentication2@REL1_35] Populate $id if we can

https://gerrit.wikimedia.org/r/648281

gerritbot added a comment.Dec 14 2020, 10:45 AM

Change 648281 merged by Robert Vogel:
[mediawiki/extensions/LDAPAuthentication2@REL1_35] Populate $id if we can

https://gerrit.wikimedia.org/r/648281

gerritbot added a comment.Dec 14 2020, 10:45 AM

Change 648280 merged by Robert Vogel:
[mediawiki/extensions/LDAPAuthentication2@REL1_31] Populate $id if we can

https://gerrit.wikimedia.org/r/648280

gerritbot added a comment.Dec 14 2020, 10:45 AM

Change 649109 merged by Robert Vogel:
[mediawiki/extensions/LDAPAuthentication2@master] Populate $id if we can

https://gerrit.wikimedia.org/r/649109

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2020, 11:10 AM
Osnard mentioned this in rELDB771b91e52b58: Populate $id if we can.Dec 14 2020, 11:21 AM
Osnard mentioned this in rELDB68c653da7be3: Populate $id if we can.
MarkAHershberger mentioned this in rELDB3a2f221adf23: Populate $id if we can.Dec 14 2020, 11:21 AM
MarkAHershberger closed this task as Resolved.Dec 14 2020, 5:10 PM
MarkAHershberger claimed this task.
gerritbot added a comment.Dec 29 2020, 12:20 AM

Change 652220 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/extensions/LDAPAuthentication2@master] Ensure that $id is populated for all existing users

https://gerrit.wikimedia.org/r/652220

gerritbot added a project: Patch-For-Review.Dec 29 2020, 12:20 AM
gerritbot added a comment.Jan 7 2021, 2:41 PM

Change 652220 merged by Robert Vogel:
[mediawiki/extensions/LDAPAuthentication2@master] Ensure that $id is populated for all existing users

https://gerrit.wikimedia.org/r/652220

gerritbot added a comment.Jan 7 2021, 2:43 PM

Change 654848 had a related patch set uploaded (by Robert Vogel; owner: MarkAHershberger):
[mediawiki/extensions/LDAPAuthentication2@REL1_35] Ensure that $id is populated for all existing users

https://gerrit.wikimedia.org/r/654848

gerritbot added a comment.Jan 7 2021, 2:44 PM

Change 654848 merged by Robert Vogel:
[mediawiki/extensions/LDAPAuthentication2@REL1_35] Ensure that $id is populated for all existing users

https://gerrit.wikimedia.org/r/654848

gerritbot added a comment.Jan 7 2021, 2:48 PM

Change 654870 had a related patch set uploaded (by Robert Vogel; owner: MarkAHershberger):
[mediawiki/extensions/LDAPAuthentication2@REL1_31] Ensure that $id is populated for all existing users

https://gerrit.wikimedia.org/r/654870

Osnard mentioned this in rELDB4ffbcefbc55c: Ensure that $id is populated for all existing users.Jan 7 2021, 2:51 PM
MarkAHershberger mentioned this in rELDB3139b8cb8951: Ensure that $id is populated for all existing users.Jan 7 2021, 2:51 PM
gerritbot added a comment.Jan 7 2021, 2:57 PM

Change 654870 merged by Robert Vogel:
[mediawiki/extensions/LDAPAuthentication2@REL1_31] Ensure that $id is populated for all existing users

https://gerrit.wikimedia.org/r/654870

Osnard mentioned this in rELDB8a0b25e22568: Ensure that $id is populated for all existing users.Jan 7 2021, 3:21 PM
CCicalese_WMF moved this task from Backlog to Closed on the MediaWiki-extensions-Pluggable-Auth board.Apr 23 2021, 10:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL