Page MenuHomePhabricator

Enable `$wgWatchlistExpiry` by default or remove it completely (TBD)
Closed, DeclinedPublic

Description

Enable $wgWatchlistExpiry by default or remove it completely

Event Timeline

I don't think it should be removed completely as there are many smaller wikis which don't require the feature and so it'd be better to avoid the UI clutter.

I don't think it should be removed completely as there are many smaller wikis which don't require the feature and so it'd be better to avoid the UI clutter.

Every feature flag in MW is a place where we never test anything and all our breakages happen. We try desperately to avoid them as much as possible.

JMcLeod_WMF subscribed.

Closing after discussion with team.

Closing after discussion with team.

Hi there,

Can you give some details as to why this is being Declined beyond just that the team agreed to do so? See my comment above.

@Jdforrester-WMF

Although this feature is useful for Wikimedia wikis (where it is already enabled by default), it is not useful for most wikis in the wild.

The choice seems to be between making our own config simpler while adding complexity to third party wikis, or maintaining the status quo which makes adds complexity to a smaller number of wikis and keeps it simpler for the greater number, noting that the amount of complexity / simplicity is fairly small regardless.

I would like to add that I have high confidence in the test suite for this feature. There we use dependency injection to set the feature flag, so we can easily run them for both scenarios (with and without the flag). They are integration tests so it will slow down CI a tiny bit, but nonetheless the coverage exists.