Page MenuHomePhabricator
Create Task
Maniphest T270088

No functional reply links on mobile
Closed, ResolvedPublic
Actions

Description

The mobile talk overlay Mobile should not show reply links (yet):

https://meta.m.wikimedia.org/wiki/Talk:Wikipedia_Asian_Month_2020#Jury_members_on_th.wikipedia

The links are visible in the default talk overlay as well as the wiki page view.

As reported in https://www.mediawiki.org/wiki/Topic:Vyx2ykowr5t1wuj1 by @Patriccck.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/DiscussionToolsmaster+9 -0Disable reply links on mobile
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Dec 14 2020, 11:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2020, 11:58 AM
Majavah added a subscriber: Majavah.Dec 14 2020, 11:58 AM
Patriccck added a subscriber: Patriccck.Dec 14 2020, 12:00 PM
Esanders renamed this task from No functional reply links on mobile talk overlay to No functional reply links on mobile.Dec 14 2020, 12:05 PM
Esanders updated the task description. (Show Details)
Esanders updated the task description. (Show Details)Dec 14 2020, 6:52 PM
gerritbot added a comment.Dec 14 2020, 6:53 PM

Change 649427 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Disable reply links on mobile

https://gerrit.wikimedia.org/r/649427

gerritbot added a project: Patch-For-Review.Dec 14 2020, 6:53 PM
Esanders claimed this task.Dec 14 2020, 6:53 PM
Esanders added a project: Editing-team (FY2021-22 Kanban Board).
Esanders moved this task from Backlog to Triaged on the DiscussionTools board.
Esanders moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
gerritbot added a comment.Dec 14 2020, 10:41 PM

Change 649427 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Disable reply links on mobile

https://gerrit.wikimedia.org/r/649427

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.Dec 14 2020, 10:51 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 14 2020, 11:10 PM
ppelberg mentioned this in T270230: Develop approach for how Reply Links should be treated where an entire comment is styled.Dec 16 2020, 6:11 AM
JTannerWMF added subscribers: ppelberg, JTannerWMF.Dec 16 2020, 6:10 PM

@ppelberg to test on Beta or group 0 wiki where DiscussionTools are enabled.

ppelberg closed this task as Resolved.Dec 24 2020, 2:51 AM
In T270088#6696440, @JTannerWMF wrote:

@ppelberg to test on Beta or group 0 wiki where DiscussionTools are enabled.

Looks good; I'm not seeing [ reply ] links here: https://fr.m.wikipedia.org/wiki/Discussion_Wikip%C3%A9dia:Sondage/Participation_aux_tests_des_nouvelles_fonctionnalit%C3%A9s_de_discussion#%C3%80_tester_en_anglais_sur_Wikip%C3%A9dia_en_fran%C3%A7ais_%3A_cherchez_l'erreur_!

matmarex mentioned this in T274311: Non-functional [Reply] button showing on mobile web.Feb 10 2021, 3:19 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL