Page MenuHomePhabricator
Create Task
Maniphest T270116

Figures should support `inline-start` and `inline-end` alignments in addition to `left` and `right`.
Open, Needs TriagePublicFeature
Actions

Description

See the definitions of inline-start and inline-end in https://developer.mozilla.org/en-US/docs/Web/CSS/float

Some existing defaults (eg, the default alignment for thumb) are actually start currently, we're just doing this in an adhoc manner.

Can I Use: float flow relative values

See T269704: Default horizontal alignment of thumbnails should depend on content language, not the UI.

Related Objects

Event Timeline

cscott created this task.Dec 14 2020, 5:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2020, 5:40 PM
cscott updated the task description. (Show Details)Dec 14 2020, 5:40 PM
cscott mentioned this in T269704: Default horizontal alignment of thumbnails should depend on content language, not the UI.
ssastry moved this task from Needs Triage to Feature requests on the Parsoid board.Dec 16 2020, 4:38 PM
Pols12 subscribed.Aug 11 2021, 6:58 PM
Pols12 mentioned this in T293896: Hardcoded image direction should be flipped in RTL-language translation pages.Oct 20 2021, 7:49 PM
Nikerabbit subscribed.Oct 21 2021, 6:22 AM
TheDJ updated the task description. (Show Details)Dec 23 2021, 12:32 PM
Tacsipacsi changed the subtype of this task from "Task" to "Feature Request".Mar 28 2022, 8:45 AM
Tacsipacsi added a project: RTL.
Tacsipacsi subscribed.

I think it should be done in a similar manner to how thumbs works: not using inline-{start,end} directly in the result HTML/CSS, but rewriting the input inline-{start,end} (or maybe just {start,end}?) to left or right depending on the page language. This would make sure that e.g. partially translated pages, which have mixed directionality, don’t mix the image positions.

Restricted Application added a project: I18n. · View Herald TranscriptMar 28 2022, 8:45 AM
Winston_Sung moved this task from Untriaged to RTL on the I18n board.Aug 9 2023, 3:16 PM
Pols12 mentioned this in T283210: Support :dir() for better RTL language support in template styles.Feb 14 2024, 2:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL