Page MenuHomePhabricator

jsonschema-tools should ensure schema examples exist
Closed, ResolvedPublic

Description

In https://gerrit.wikimedia.org/r/c/schemas/event/secondary/+/646846 we merged a schema without examples, and a stream using that schema configured it with canary_events_enabled: true (as it should). We build canary events from the schema examples. This caused the canary events job to fail.

jsonschema-tools should be able to ensure that examples exist.

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Never use $refed schema examplesrepos/data-engineering/jsonschema-tools!37ebysansgithub/fork/ottomata/mastermaster
When resolving allOf examples, only keep one examples listrepos/data-engineering/jsonschema-tools!33ebysansgithub/fork/ottomata/mastermaster
Add option to generate schema examplerepos/data-engineering/jsonschema-tools!23ebysansgithub/fork/ottomata/examples-generatemaster
Customize query in GitLab

Event Timeline

Ottomata renamed this task from jsonschema-tools should have option to require examples to jsonschema-tools should ensure schema examples exist.Dec 17 2020, 2:23 AM
Ottomata updated the task description. (Show Details)
fdans moved this task from Incoming to Event Platform on the Analytics board.
Ottomata claimed this task.

Change 691236 had a related patch set uploaded (by Ottomata; author: Ottomata):

[schemas/event/secondary@master] Enable shouldGenerateExample

https://gerrit.wikimedia.org/r/691236

Change 691236 merged by jenkins-bot:

[schemas/event/secondary@master] Enable shouldGenerateExample

https://gerrit.wikimedia.org/r/691236

Change 702700 had a related patch set uploaded (by Ottomata; author: Ottomata):

[schemas/event/secondary@master] Rematerialize fragment schemas with generated examples.

https://gerrit.wikimedia.org/r/702700

Change 703250 had a related patch set uploaded (by Ottomata; author: Ottomata):

[schemas/event/primary@master] Set shouldGenerateExample: true and rematerialize schemas to get examples everywhere

https://gerrit.wikimedia.org/r/703250

Change 703250 merged by jenkins-bot:

[schemas/event/primary@master] Set shouldGenerateExample: true and rematerialize schemas to get examples everywhere

https://gerrit.wikimedia.org/r/703250

Change 702700 merged by jenkins-bot:

[schemas/event/secondary@master] Rematerialize fragment schemas with generated examples.

https://gerrit.wikimedia.org/r/702700