Page MenuHomePhabricator

White space before top of page meta items is removed
Open, LowPublic



Possibly a regression as I don’t remember seeing these before last week.

Event Timeline

ssastry triaged this task as Medium priority.Dec 15 2020, 4:20 PM
ssastry lowered the priority of this task from Medium to Low.Dec 15 2020, 4:25 PM
ssastry added a subscriber: ssastry.

This is not a regression. It is just an old bug. The --scrubWikitext option strips the whitespace to avoid adding a <nowiki> </nowiki>. So, the "bug" is in the nowiki-prevention code. Looks like presence of templates is what causes that because the nowiki code doesn't look inside the template to know that the leading whitespace is harmless for other reasons (ex: <div> tag on the line). We are probably not going to fix that since it does not seem worth the complexity for an occasional harmless dirty diff.

The selser patch I pushed recently doesn't prevent this dirty diff either since it looks for separator-runs between nodes but probably needs a special case for the very first non-separator-node of <body>. So, that is probably a better place to tweak this.

Change 649747 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: Handle selser edge case for first content-node of <body>

Change 649747 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Handle selser edge case for first content-node of <body>

Change 655482 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a22

Change 655482 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a22