Page MenuHomePhabricator
Create Task
Maniphest T270237

Adjust bracket matching limits to include bigger paragraphs
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
thiemowmde
Authored By
WMDE-Fisch
Dec 16 2020, 9:10 AM
Tags
Referenced Files
F33996712: Screenshot from 2021-01-12 16-30-59_10000_new.png
Jan 12 2021, 3:43 PM
F33996713: Screenshot from 2021-01-12 16-15-22_1000_new.png
Jan 12 2021, 3:43 PM
Subscribers
Aklapper
thiemowmde
WMDE-Fisch

Description

There seem to be limits in place the disable bracket matching in bigger paragraphs. Currently these limits seem to be relatively low.

  • Find places where limits are applied and can be adjusted.
  • Figure out a reasonable number.

For reference - the following paragraph seems too long

[[Link]] aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix performance bottleneck in mediawiki syntax highlightermediawiki/extensions/CodeMirrormaster+44 -43
Lower maxHighlightLineLength limit to 5000mediawiki/extensions/CodeMirrormaster+2 -2
Fix remaining bottleneck in wikitext syntax highlightermediawiki/extensions/CodeMirrormaster+1 -1
Lower maxHighlightLineLength limit to 5000mediawiki/extensions/CodeMirrorwmf/1.36.0-wmf.27+2 -2
Activate bracket matching for longer linesmediawiki/extensions/CodeMirrormaster+2 -2
Enable bracket matching addon by defining the addons optionsmediawiki/extensions/CodeMirrormaster+22 -9
Customize query in gerrit

Related Objects

Event Timeline

WMDE-Fisch created this task.Dec 16 2020, 9:10 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptDec 16 2020, 9:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lena_WMDE moved this task from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.Dec 16 2020, 9:22 AM
Lena_WMDE set the point value for this task to 3.
thiemowmde mentioned this in T270317: Optimization and limits for bracket matching.Dec 16 2020, 5:23 PM
Lena_WMDE added a project: WMDE-QWERTY-Sprint-2021-01-06.Jan 6 2021, 9:43 AM
WMDE-Fisch moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Jan 6 2021, 9:46 AM
gerritbot added a comment.Jan 12 2021, 10:54 AM

Change 655631 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/CodeMirror@master] Enable bracket matching addon by defining the addons options

https://gerrit.wikimedia.org/r/655631

gerritbot added a project: Patch-For-Review.Jan 12 2021, 10:54 AM
gerritbot added a comment.Jan 12 2021, 11:07 AM

Change 655631 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Enable bracket matching addon by defining the addons options

https://gerrit.wikimedia.org/r/655631

Maintenance_bot removed a project: Patch-For-Review.Jan 12 2021, 11:10 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 12 2021, 12:00 PM
gerritbot added a comment.Jan 12 2021, 3:12 PM

Change 655689 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/CodeMirror@master] Fix performance bottleneck in mediawiki syntax highlighter

https://gerrit.wikimedia.org/r/655689

gerritbot added a project: Patch-For-Review.Jan 12 2021, 3:12 PM
gerritbot added a comment.Jan 12 2021, 3:35 PM

Change 655694 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/CodeMirror@master] Activate bracket matching for longer lines

https://gerrit.wikimedia.org/r/655694

thiemowmde claimed this task.Jan 12 2021, 3:43 PM
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2021-01-06 board.
thiemowmde subscribed.

With the performance fix in place (gerrit:655689), these are the flamegraphs for the two line length settings. The default 1000 at the top, the increased 10000 at the bottom.

Screenshot from 2021-01-12 16-30-59_10000_new.png (394×1 px, 46 KB)
Screenshot from 2021-01-12 16-15-22_1000_new.png (372×1 px, 64 KB)

The keydown event is when I change the text, and everything (not only bracket matching but the entire syntax highlighting) is redone. It changes from 6ms to 17ms simply because the line I benchmark is 10x longer and 10x more syntax highlighting needs to be done (but it doesn't need 10x the time, which is great). The bracket matching addon is on the very left of the flamegraph, barely visible, less than 1ms in both flamegraphs. In other words: The increase in gerrit:655694 does not have an effect on the performance.

gerritbot added a comment.Jan 14 2021, 11:22 AM

Change 655689 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Fix performance bottleneck in mediawiki syntax highlighter

https://gerrit.wikimedia.org/r/655689

gerritbot added a comment.Jan 14 2021, 11:46 AM

Change 655694 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Activate bracket matching for longer lines

https://gerrit.wikimedia.org/r/655694

Maintenance_bot removed a project: Patch-For-Review.Jan 14 2021, 12:10 PM
WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2021-01-06 board.Jan 14 2021, 12:25 PM
Lena_WMDE closed this task as Resolved.Jan 19 2021, 9:16 AM
Lena_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2021-01-06 board.
gerritbot added a comment.Jan 19 2021, 2:12 PM

Change 657088 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/CodeMirror@master] Lower maxHighlightLineLength limit to 5000

https://gerrit.wikimedia.org/r/657088

gerritbot added a project: Patch-For-Review.Jan 19 2021, 2:12 PM
gerritbot added a comment.Jan 20 2021, 10:03 AM

Change 657088 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Lower maxHighlightLineLength limit to 5000

https://gerrit.wikimedia.org/r/657088

gerritbot added a comment.Jan 20 2021, 10:06 AM

Change 657308 had a related patch set uploaded (by WMDE-Fisch; owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/CodeMirror@wmf/1.36.0-wmf.27] Lower maxHighlightLineLength limit to 5000

https://gerrit.wikimedia.org/r/657308

gerritbot added a comment.Jan 25 2021, 3:09 PM

Change 657308 abandoned by Awight:
[mediawiki/extensions/CodeMirror@wmf/1.36.0-wmf.27] Lower maxHighlightLineLength limit to 5000

Reason:
1 backporting no longer necessary, the master patch will be included in this week's train.

https://gerrit.wikimedia.org/r/657308

gerritbot added a comment.Feb 5 2021, 3:20 PM

Change 661948 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/CodeMirror@master] Fix remaining bottleneck in wikitext syntax highlighter

https://gerrit.wikimedia.org/r/661948

gerritbot added a comment.Feb 8 2021, 11:15 AM

Change 661948 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Fix remaining bottleneck in wikitext syntax highlighter

https://gerrit.wikimedia.org/r/661948

thiemowmde mentioned this in T254958: Syntax highlighting causes Firefox tab to freeze on long pages while editing.Apr 23 2021, 5:49 PM
Izno moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Aug 19 2021, 7:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits