Page MenuHomePhabricator

Adjust bracket matching limits to include bigger paragraphs
Closed, ResolvedPublic3 Estimated Story Points

Description

There seem to be limits in place the disable bracket matching in bigger paragraphs. Currently these limits seem to be relatively low.

  • Find places where limits are applied and can be adjusted.
  • Figure out a reasonable number.

For reference - the following paragraph seems too long

[[Link]] aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lena_WMDE set the point value for this task to 3.

Change 655631 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/CodeMirror@master] Enable bracket matching addon by defining the addons options

https://gerrit.wikimedia.org/r/655631

Change 655631 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Enable bracket matching addon by defining the addons options

https://gerrit.wikimedia.org/r/655631

Change 655689 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/CodeMirror@master] Fix performance bottleneck in mediawiki syntax highlighter

https://gerrit.wikimedia.org/r/655689

Change 655694 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/CodeMirror@master] Activate bracket matching for longer lines

https://gerrit.wikimedia.org/r/655694

thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2021-01-06 board.
thiemowmde added a subscriber: thiemowmde.

With the performance fix in place (gerrit:655689), these are the flamegraphs for the two line length settings. The default 1000 at the top, the increased 10000 at the bottom.

Screenshot from 2021-01-12 16-30-59_10000_new.png (394×1 px, 46 KB)
Screenshot from 2021-01-12 16-15-22_1000_new.png (372×1 px, 64 KB)

The keydown event is when I change the text, and everything (not only bracket matching but the entire syntax highlighting) is redone. It changes from 6ms to 17ms simply because the line I benchmark is 10x longer and 10x more syntax highlighting needs to be done (but it doesn't need 10x the time, which is great). The bracket matching addon is on the very left of the flamegraph, barely visible, less than 1ms in both flamegraphs. In other words: The increase in gerrit:655694 does not have an effect on the performance.

Change 655689 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Fix performance bottleneck in mediawiki syntax highlighter

https://gerrit.wikimedia.org/r/655689

Change 655694 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Activate bracket matching for longer lines

https://gerrit.wikimedia.org/r/655694

Lena_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2021-01-06 board.

Change 657088 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/CodeMirror@master] Lower maxHighlightLineLength limit to 5000

https://gerrit.wikimedia.org/r/657088

Change 657088 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Lower maxHighlightLineLength limit to 5000

https://gerrit.wikimedia.org/r/657088

Change 657308 had a related patch set uploaded (by WMDE-Fisch; owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/CodeMirror@wmf/1.36.0-wmf.27] Lower maxHighlightLineLength limit to 5000

https://gerrit.wikimedia.org/r/657308

Change 657308 abandoned by Awight:
[mediawiki/extensions/CodeMirror@wmf/1.36.0-wmf.27] Lower maxHighlightLineLength limit to 5000

Reason:
1 backporting no longer necessary, the master patch will be included in this week's train.

https://gerrit.wikimedia.org/r/657308

Change 661948 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/CodeMirror@master] Fix remaining bottleneck in wikitext syntax highlighter

https://gerrit.wikimedia.org/r/661948

Change 661948 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Fix remaining bottleneck in wikitext syntax highlighter

https://gerrit.wikimedia.org/r/661948