Page MenuHomePhabricator
Create Task
Maniphest T270294

Scale: deploy without impact module
Closed, ResolvedPublic
Actions

Description

In order to deploy the Growth features to Bengali Wikipedia (via T266020), we need to suppress the impact module. This is so that the module does not conflict with a separate experiment being run by another team around impact statistics. Then in a few months, we will want to turn it on.

Details

ProjectBranchLines +/-Subject
schemas/event/secondarymaster+519 -4homepagevisit: Add new state for impact module
mediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.31+15 -4Impact module: Add "not rendered" state
mediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.32+15 -4Impact module: Add "not rendered" state
mediawiki/extensions/GrowthExperimentsmaster+15 -4Impact module: Add "not rendered" state
operations/mediawiki-configmaster+1 -1testwiki: Bump HomepageVisit EventLogging schema version
mediawiki/extensions/GrowthExperimentsmaster+6 -2Make it possible to disable the impact module
Customize query in gerrit

Related Objects
Search...

Event Timeline

MMiller_WMF created this task.Dec 16 2020, 2:59 PM
MMiller_WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
gerritbot added a comment.Dec 17 2020, 12:09 AM

Change 649995 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] Make it possible to disable the impact module

https://gerrit.wikimedia.org/r/649995

gerritbot added a project: Patch-For-Review.Dec 17 2020, 12:09 AM
Urbanecm_WMF claimed this task.Dec 17 2020, 12:11 AM
Urbanecm_WMF moved this task from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Restricted Application added a project: User-Urbanecm_WMF. · View Herald TranscriptDec 17 2020, 12:11 AM
Urbanecm_WMF moved this task from Untriaged to Engineering on the User-Urbanecm_WMF board.Dec 17 2020, 12:11 AM
Urbanecm_WMF edited projects, added User-Urbanecm_WMF (Engineering); removed User-Urbanecm_WMF.
Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.
Tgr closed this task as Resolved.Dec 17 2020, 1:25 AM

Can't really be QA'd in itself.

gerritbot added a comment.Dec 17 2020, 1:35 AM

Change 649995 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Make it possible to disable the impact module

https://gerrit.wikimedia.org/r/649995

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 17 2020, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 17 2020, 2:10 AM
Urbanecm_WMF added a comment.EditedDec 18 2020, 6:52 PM

I can confirm there is no impact module at bnwiki beta.

RHo mentioned this in T274793: Turn on Impact module for Bengali Wikipedia after conclusion of another impact stats experiment.Feb 15 2021, 2:53 PM
gerritbot added a comment.Feb 24 2021, 1:08 PM

Change 666619 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[schemas/event/secondary@master] homepagevisit: Make impact_module_state optional

https://gerrit.wikimedia.org/r/666619

gerritbot added a project: Patch-For-Review.Feb 24 2021, 1:08 PM
kostajh mentioned this in T275615: 'impact_module_state' is a required property.Feb 24 2021, 1:09 PM
gerritbot added a comment.Feb 24 2021, 1:22 PM

Change 666620 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Impact module: Add "not rendered" state

https://gerrit.wikimedia.org/r/666620

gerritbot added a comment.Feb 24 2021, 1:26 PM

Change 666621 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[operations/mediawiki-config@master] testwiki: Bump HomepageVisit EventLogging schema version

https://gerrit.wikimedia.org/r/666621

gerritbot added a comment.Feb 25 2021, 8:38 AM

Change 666621 abandoned by Kosta Harlan:
[operations/mediawiki-config@master] testwiki: Bump HomepageVisit EventLogging schema version

Reason:
Not needed due to If4062472a285238d8763e88a046e8b7b65b18ad1

https://gerrit.wikimedia.org/r/666621

mewoph moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Feb 25 2021, 4:39 PM
gerritbot added a comment.Feb 25 2021, 4:54 PM

Change 666620 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Impact module: Add "not rendered" state

https://gerrit.wikimedia.org/r/666620

gerritbot added a comment.Feb 25 2021, 7:14 PM

Change 666704 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.32] Impact module: Add "not rendered" state

https://gerrit.wikimedia.org/r/666704

gerritbot added a comment.Feb 25 2021, 7:30 PM

Change 666704 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.32] Impact module: Add "not rendered" state

https://gerrit.wikimedia.org/r/666704

Stashbot added a comment.Feb 25 2021, 7:40 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-25T19:40:37Z] <tgr@deploy1001> Synchronized php-1.36.0-wmf.32/extensions/GrowthExperiments/: Backport: [[gerrit:666704|Impact module: Add "not rendered" state (T270294, T275615)]] (duration: 01m 26s)

gerritbot added a comment.Feb 25 2021, 7:41 PM

Change 666986 had a related patch set uploaded (by Gergő Tisza; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.31] Impact module: Add "not rendered" state

https://gerrit.wikimedia.org/r/666986

gerritbot added a comment.Feb 25 2021, 7:57 PM

Change 666986 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.31] Impact module: Add "not rendered" state

https://gerrit.wikimedia.org/r/666986

Stashbot added a comment.Feb 25 2021, 8:17 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-25T20:17:05Z] <tgr@deploy1001> Synchronized php-1.36.0-wmf.31/extensions/GrowthExperiments/: Backport: [[gerrit:666704|Impact module: Add "not rendered" state (T270294, T275615)]] (duration: 01m 08s)

gerritbot added a comment.Mar 1 2021, 3:25 PM

Change 666619 merged by Gergő Tisza:
[schemas/event/secondary@master] homepagevisit: Add new state for impact module

https://gerrit.wikimedia.org/r/666619

Maintenance_bot removed a project: Patch-For-Review.Mar 12 2021, 9:56 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL