| Niharika | |
| Dec 16 2020, 3:51 PM |
| F33947793: image.png | |
| Dec 17 2020, 5:23 AM |
| F33947791: image.png | |
| Dec 17 2020, 5:23 AM |
| F33947783: image.png | |
| Dec 17 2020, 4:54 AM |
| F33932274: image.png | |
| Dec 16 2020, 3:51 PM |
This task is to add the informative banner on the bottom-right of the mockup below to the IP Information box. We want to indicate the source of the data (MaxMind) and give a disclaimer about the data potentially being inaccurate.
Text: The information shown here comes from the GeoIP2 databases from MaxMind. It might not be fully accurate.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update info source text with a disclaimer | mediawiki/extensions/IPInfo | master | +19 -20 |
Given that we want to put different (first-party) information into the popup (thereby negating the need for the third-party disclaimer?) but that we're not sure how or what we can readily access (ie. when we can finish it), do we want to consider how this looks for the popup right now while we're doing user testing? For reference the popup looks like this right now:
Change 650019 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/extensions/IPInfo@master] Update info source text with a disclaimer
Here's how it looks with my changes (based on the assumption that the popup and the infobox will continue to use similar displays)
This is looking great @STran! Thanks for sharing the screenshots. I'll make follow-up tasks for the padding things we talked about.
Change 650019 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Update info source text with a disclaimer