PHP Warning: json_decode() expects parameter 1 to be string, array given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	• holger.knust
	Dec 16 2020, 7:09 PM

Project Tags

Referenced Files

None

Subscribers

Description

Error

MediaWiki version: 1.36.0-wmf.21

message

PHP Warning: json_decode() expects parameter 1 to be string, array given

Impact

Notes

Details

Request ID: X9pXJApAMNsAA9TFXSQAAABB
Request URL: https://meta.wikimedia.org/w/rest.php/oauth2/client?limit=5&oauth_version=2&sort=%7B%22property%22%3A%22registration%22%2C%22direction%22%3A%22DESC%22%7D

Stack Trace

exception.trace

#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.21/includes/json/FormatJson.php(175): json_decode(array, integer)
#2 /srv/mediawiki/php-1.36.0-wmf.21/extensions/OAuth/src/Rest/Handler/ListClients.php(201): FormatJson::decode(array, integer)
#3 /srv/mediawiki/php-1.36.0-wmf.21/extensions/OAuth/src/Rest/Handler/ListClients.php(159): MediaWiki\Extensions\OAuth\Rest\Handler\ListClients->processDbResults(Wikimedia\Rdbms\ResultWrapper)
#4 /srv/mediawiki/php-1.36.0-wmf.21/extensions/OAuth/src/Rest/Handler/ListClients.php(88): MediaWiki\Extensions\OAuth\Rest\Handler\ListClients->getDbResults(integer)
#5 /srv/mediawiki/php-1.36.0-wmf.21/includes/Rest/SimpleHandler.php(38): MediaWiki\Extensions\OAuth\Rest\Handler\ListClients->run()
#6 /srv/mediawiki/php-1.36.0-wmf.21/includes/Rest/Router.php(389): MediaWiki\Rest\SimpleHandler->execute()
#7 /srv/mediawiki/php-1.36.0-wmf.21/includes/Rest/Router.php(316): MediaWiki\Rest\Router->executeHandler(MediaWiki\Extensions\OAuth\Rest\Handler\ListClients)
#8 /srv/mediawiki/php-1.36.0-wmf.21/includes/Rest/EntryPoint.php(152): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#9 /srv/mediawiki/php-1.36.0-wmf.21/includes/Rest/EntryPoint.php(117): MediaWiki\Rest\EntryPoint->execute()
#10 /srv/mediawiki/php-1.36.0-wmf.21/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#11 /srv/mediawiki/w/rest.php(3): require(string)
#12 {main}

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Don't json decode oauth2GrantTypes in Rest clients listing	Ammarpad	mediawiki/extensions/OAuth	master	+1 -2

Customize query in gerrit

Event Timeline

• holger.knust created this task.Dec 16 2020, 7:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2020, 7:09 PM

thcipriani added a project: MediaWiki-extensions-OAuth.Dec 16 2020, 7:46 PM

thcipriani moved this task from Untriaged to Dec 2020 on the Wikimedia-production-error board.

Probably this might be a simple error where the values are supposed to be 'encoded' to json, but 'decode' was called. The input 'oauth2GrantTypes' is clearly an array, and the output is suppose to be in json.

• Clarakosi triaged this task as High priority.Dec 22 2020, 9:09 PM

• Clarakosi edited projects, added: Platform Team Workboards (Clinic Duty Team); removed: Platform Engineering.

• Clarakosi moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.

With decoding
{"clients":[{"name":"Hello World"..."allowed_grants":null,"scopes":["basic","editprotected","editmycssjs","createeditmovepage","patrol"]}],"total":1}

Without decoding
{"clients":[{"name":"Hello World"..."allowed_grants":["importupload","apihighlimits"],"scopes":["basic","editprotected","editmycssjs","createeditmovepage","patrol"]}],"total":1}

Change 651690 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/OAuth@master] Don't json decode oauth2GrantTypes in Rest clients listing

https://gerrit.wikimedia.org/r/651690

gerritbot added a project: Patch-For-Review.Dec 23 2020, 5:02 AM

Change 651690 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Don't json decode oauth2GrantTypes in Rest clients listing

https://gerrit.wikimedia.org/r/651690

Thanks, @Ammarpad!

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Jan 4 2021, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 4 2021, 8:11 PM

PHP Warning: json_decode() expects parameter 1 to be string, array givenClosed, ResolvedPublicPRODUCTION ERRORActions