Page MenuHomePhabricator

z-index:auto on rcfilters multiselect widgets results in them appearing behind content on most skins
Closed, ResolvedPublic

Description

Not overriding the default (z-index: 4) fixes nearly all of them. Anything else, the rest of ooui probably needs a skin-specific fix anyway, so that's kind of on the skin to sort out.

Some skins avoid this by having different layering, or explicitly setting their own overrides, but removing this doesn't seem to hurt them either.

Affected skins from a brief check: GreyStuff, Example, CologneBlue, WoOgLeShades, quite a few others
Unaffected skins: Modern, Timeless, Vector, MonoBook

See:

image.png (884×919 px, 103 KB)

(Seriously, if it's broken in Example, we have a problem. Example barely even has any styles to conflict with.)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 649982 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/core@master] Don't override ooui z-index on rcfilters menuselect widgets

https://gerrit.wikimedia.org/r/649982

Change 649982 merged by jenkins-bot:
[mediawiki/core@master] Prevent rcfilters menuselect widgets from winding up behind content on some skins

https://gerrit.wikimedia.org/r/649982

• matmarex assigned this task to Isarra.
• matmarex subscribed.

Change 961713 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] rcfilters: Increase the z-index of the overlay to @z-index-dropdown

https://gerrit.wikimedia.org/r/961713

Change #961713 abandoned by Hashar:

[mediawiki/core@master] rcfilters: Increase the z-index of the overlay to @z-index-dropdown

https://gerrit.wikimedia.org/r/961713

Change #961713 restored by Thcipriani:

[mediawiki/core@master] rcfilters: Increase the z-index of the overlay to @z-index-dropdown

https://gerrit.wikimedia.org/r/961713

Change #961713 abandoned by Bartosz Dziewoński:

[mediawiki/core@master] rcfilters: Increase the z-index of the overlay to @z-index-dropdown

Reason:

The associated task is resolved, so I think this is no longer needed.

https://gerrit.wikimedia.org/r/961713