Page MenuHomePhabricator
Create Task
Maniphest T270381

Include gsrprop & gsrsinfo data in search api generator response
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Once T263841 becomes accepted, the search API will be allowed to expose additional data when used as a generator.

All of the data that is currently exposed (in list mode) under srprop and srinfo properties should become available (in generator mode) under gsrprop and gsrinfo. That is:

  • gsrinfo: rewrittenquery, suggestion, totalhits
  • gsrprop: categorysnippet, extensiondata, isfilematch, redirectsnippet, redirecttitle, sectionsnippet, sectiontitle, size, snippet, timestamp, titlesnippet, wordcount

Note that (unlike in list mode) none of that data should be included in the response by default - it should only be added when the gsrprop or gsrinfo params explicitly request the data.

Details

SubjectRepoBranchLines +/-
ApiQuerySearch: Include prop/info when requested in generator modemediawiki/coremaster+33 -23
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Dec 17 2020, 12:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 17 2020, 12:38 PM
matthiasmullie moved this task from Incoming to Blocked on the Structured-Data-Backlog (Current Work) board.Dec 17 2020, 12:38 PM
matthiasmullie mentioned this in T269383: [M] Media Search: Surfacing the result count.
matthiasmullie mentioned this in T260292: [M] Add "did you mean" feature to Media Search.Dec 17 2020, 12:41 PM
matthiasmullie mentioned this in T262992: Add formatted page/file size.Dec 17 2020, 12:46 PM
CBogen moved this task from needs triage to Current work on the Discovery-Search board.Jan 4 2021, 4:09 PM
CBogen edited projects, added Discovery-Search (Current work); removed Discovery-Search.
CBogen set the point value for this task to 3.Jan 4 2021, 4:57 PM
CBogen moved this task from Incoming to Blocked/Waiting on the Discovery-Search (Current work) board.
CBogen moved this task from Blocked/Waiting to Ready for Dev -- SWE on the Discovery-Search (Current work) board.Jan 11 2021, 4:44 PM
matthiasmullie added a comment.Jan 12 2021, 7:26 AM

Will search platform or structured data implement this? I'm ok with either, just want to make sure we don't end up both doing the same work.

CBogen subscribed.Jan 12 2021, 1:06 PM
In T270381#6738646, @matthiasmullie wrote:

Will search platform or structured data implement this? I'm ok with either, just want to make sure we don't end up both doing the same work.

Search Platform will handle it, thanks for checking!

• Zbyszko moved this task from Ready for Dev -- SWE to In Progress on the Discovery-Search (Current work) board.Jan 12 2021, 1:48 PM
• Zbyszko moved this task from In Progress to Ready for Dev -- SWE on the Discovery-Search (Current work) board.Jan 12 2021, 1:53 PM
AnneT subscribed.Jan 12 2021, 6:03 PM
dcausse added subscribers: EBernhardson, dcausse.Jan 19 2021, 2:27 PM

related patch by @EBernhardson: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/394120

EBernhardson claimed this task.Jan 19 2021, 10:20 PM

also more recent patch by @matthiasmullie https://gerrit.wikimedia.org/r/c/mediawiki/core/+/592407

EBernhardson moved this task from Ready for Dev -- SWE to In Progress on the Discovery-Search (Current work) board.Jan 19 2021, 10:20 PM
gerritbot added a comment.Jan 20 2021, 1:13 AM

Change 394120 had a related patch set uploaded (by Ebernhardson; owner: Ebernhardson):
[mediawiki/core@master] Include highlight snippets when using search as api generator

https://gerrit.wikimedia.org/r/394120

gerritbot added a project: Patch-For-Review.Jan 20 2021, 1:13 AM
EBernhardson moved this task from In Progress to Needs review on the Discovery-Search (Current work) board.Jan 20 2021, 1:17 AM
matthiasmullie moved this task from Blocked to Needs QA on the Structured-Data-Backlog (Current Work) board.Jan 21 2021, 12:25 PM
gerritbot added a comment.Jan 21 2021, 12:53 PM

Change 394120 merged by jenkins-bot:
[mediawiki/core@master] ApiQuerySearch: Include prop/info when requested in generator mode

https://gerrit.wikimedia.org/r/394120

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 21 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 21 2021, 1:10 PM
EBernhardson moved this task from Needs review to To Be Deployed on the Discovery-Search (Current work) board.Jan 25 2021, 4:38 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Jan 27 2021, 1:52 AM
CBogen moved this task from To Be Deployed to Needs Reporting on the Discovery-Search (Current work) board.Feb 1 2021, 4:33 PM
Gehel removed a project: Discovery-Search (Current work).Feb 3 2021, 8:55 AM
Gehel subscribed.

This is done from the Search Platform side of things. I'm removing us from this task, but keeping it opened since there seems to still be verification work on the Structured Data side. Re-assign us as needed!

Etonkovidova closed this task as Resolved.Feb 12 2021, 1:21 AM
Etonkovidova subscribed.

Checked in commons wmf.30 along with T262992: Add formatted page/file size.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL