Page MenuHomePhabricator

Include gsrprop & gsrsinfo data in search api generator response
Closed, ResolvedPublic3 Estimated Story Points

Description

Once T263841 becomes accepted, the search API will be allowed to expose additional data when used as a generator.

All of the data that is currently exposed (in list mode) under srprop and srinfo properties should become available (in generator mode) under gsrprop and gsrinfo. That is:

  • gsrinfo: rewrittenquery, suggestion, totalhits
  • gsrprop: categorysnippet, extensiondata, isfilematch, redirectsnippet, redirecttitle, sectionsnippet, sectiontitle, size, snippet, timestamp, titlesnippet, wordcount

Note that (unlike in list mode) none of that data should be included in the response by default - it should only be added when the gsrprop or gsrinfo params explicitly request the data.

Event Timeline

Will search platform or structured data implement this? I'm ok with either, just want to make sure we don't end up both doing the same work.

Will search platform or structured data implement this? I'm ok with either, just want to make sure we don't end up both doing the same work.

Search Platform will handle it, thanks for checking!

Change 394120 had a related patch set uploaded (by Ebernhardson; owner: Ebernhardson):
[mediawiki/core@master] Include highlight snippets when using search as api generator

https://gerrit.wikimedia.org/r/394120

Change 394120 merged by jenkins-bot:
[mediawiki/core@master] ApiQuerySearch: Include prop/info when requested in generator mode

https://gerrit.wikimedia.org/r/394120

Gehel added a subscriber: Gehel.

This is done from the Search Platform side of things. I'm removing us from this task, but keeping it opened since there seems to still be verification work on the Structured Data side. Re-assign us as needed!

Etonkovidova added a subscriber: Etonkovidova.

Checked in commons wmf.30 along with T262992: Add formatted page/file size.