Use configured thumblimits rather than a hardcoded array of thumbnail widths
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matthiasmullie
	Dec 17 2020, 2:16 PM

Description

Thumbnails are already being requested at certain sizes that are likely to be warm in cache.
This seems to work well, but we should use the thumblimits config value (and their 1.5x and 2x versions) rather than having a hardcoded list of widths in there.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use configured thumblimits instead of hardcoded list	mediawiki/extensions/WikibaseMediaInfo	master	+26 -5

Customize query in gerrit

Event Timeline

matthiasmullie created this task.Dec 17 2020, 2:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 17 2020, 2:16 PM

matthiasmullie moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.Dec 17 2020, 2:16 PM

Change 650122 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Use configured thumblimits instead of hardcoded list

https://gerrit.wikimedia.org/r/650122

gerritbot added a project: Patch-For-Review.Dec 17 2020, 2:17 PM

CBogen added a project: MediaSearch (MediaSearch-ReleaseCandidate2).Dec 17 2020, 3:17 PM

Change 650122 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Use configured thumblimits instead of hardcoded list

https://gerrit.wikimedia.org/r/650122

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 13 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2021, 5:10 PM

AnneT moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jan 15 2021, 9:37 PM

Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Jan 20 2021, 12:48 AM

Etonkovidova closed this task as Resolved.Jan 21 2021, 12:00 AM