Page MenuHomePhabricator
Create Task
Maniphest T270400

Display available subtitles in thumbnail
Closed, ResolvedPublicFeature
Actions

Description

Problem: Some people really prefer, or need even, subtitles in order to find videos useful. Some to the extent that they don't even click videos since they so rarely have subtitles.

Suggestion: When there is a subtitle available, make an icon revealing the existence of subtitles directly in the thumbnail.

Details

SubjectRepoBranchLines +/-
Fix CC labels on small thumbnailsmediawiki/extensions/TimedMediaHandlermaster+9 -9
Add CC and duration labels on top of the placeholdermediawiki/extensions/TimedMediaHandlermaster+111 -1
Customize query in gerrit

Related Objects

Event Timeline

Ainali created this task.Dec 17 2020, 4:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 17 2020, 4:02 PM
Aklapper changed the subtype of this task from "Task" to "Feature Request".Dec 17 2020, 5:08 PM
TheDJ triaged this task as Low priority.Feb 18 2022, 12:59 PM
TheDJ added a project: VideoJS player.
TheDJ subscribed.

I like this idea. we should do the same for duration !

TheDJ added a comment.Feb 20 2022, 3:28 PM

Screenshot 2022-02-20 at 16.21.20.png (620×944 px, 797 KB)
I've made a small example of this. It's not yet finished, as it still needs some i18n labels.

gerritbot added a comment.Feb 20 2022, 3:33 PM

Change 763945 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] [WIP] Add CC and duration labels on top of the placeholder

https://gerrit.wikimedia.org/r/763945

gerritbot added a project: Patch-For-Review.Feb 20 2022, 3:33 PM
gerritbot added a comment.Feb 28 2022, 3:00 PM

Change 763945 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Add CC and duration labels on top of the placeholder

https://gerrit.wikimedia.org/r/763945

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2022, 3:11 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 28 2022, 4:00 PM
TheDJ closed this task as Resolved.Mar 1 2022, 12:34 PM
TheDJ claimed this task.
gerritbot added a comment.Mar 1 2022, 12:48 PM

Change 767114 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Fix CC labels on small thumbnails

https://gerrit.wikimedia.org/r/767114

gerritbot added a project: Patch-For-Review.Mar 1 2022, 12:48 PM
gerritbot added a comment.Mar 1 2022, 1:30 PM

Change 767114 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Fix CC labels on small thumbnails

https://gerrit.wikimedia.org/r/767114

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.25; 2022-03-07); removed MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Mar 1 2022, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 1 2022, 2:11 PM
Iniquity mentioned this in T302149: Replace icons in control panel of VideoJS player.Mar 2 2022, 6:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL