Page MenuHomePhabricator

Validate graph data or inputs and present feedback to the editor/reader rather than rely on production error logs
Closed, DeclinedPublic

Description

T269308 has shown that the addition of a graph to a single page if badly implemented can create a spike in production error logs, even though that error is caused by user generated content.

On larger wikis if a graph was added to a popular page the volume here could be catastrophic and overload the service.

We need a way to validate both graph definitions and csv data sources. Error feedback should be presented to the editor/reader rather than relying on error logs.

Event Timeline

MSantos subscribed.

From the maintainers wiki page I'm tagging the Editing-team and removing PI, please let me know if you have any questions or concerns.

This is no longer a production error as it is caught and instead errors to the console, but the error still exists.

@Jseddon how complicated would it be be to add validation to the JSONs provided by editors, prior to attempting to render them?