Page MenuHomePhabricator
Create Task
Maniphest T270479

Move EntitySourceDefinitions and Settings from WikibaseRepo to service container
Closed, ResolvedPublic
Actions

Description

These two services are the last constructor parameters of the WikibaseRepo class, and they have to be moved to services together, because the Settings contain the name of the default entity source; if we move one but not the other, then some tests will start to get confused.

Patch-For-Review:

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE claimed this task.Dec 18 2020, 11:07 AM
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Claiming this because I already worked on it before; it looks like I’ve finally got it working, and can take the related changes out of WIP (and attach them to this task, now that it exists).

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Dec 18 2020, 11:15 AM
gerritbot added a comment.Dec 18 2020, 11:19 AM

Change 648305 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] LexemeHandlerTest: override two methods

https://gerrit.wikimedia.org/r/648305

gerritbot added a project: Patch-For-Review.Dec 18 2020, 11:19 AM

Change 648306 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseCirrusSearch@master] ItemHandlerTest, PropertyHandlerTest: override two methods

https://gerrit.wikimedia.org/r/648306

gerritbot added a comment.Dec 18 2020, 11:20 AM

Change 648307 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] LexemeHandlerTest: override two methods

https://gerrit.wikimedia.org/r/648307

gerritbot added a comment.Dec 18 2020, 11:52 AM

Change 648308 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] EntityHandlerTestCase: don’t call getHandler() from data providers

https://gerrit.wikimedia.org/r/648308

gerritbot added a comment.Dec 18 2020, 11:52 AM

Change 649373 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] EntityHandlerTestCase: don’t hard-code item+property

https://gerrit.wikimedia.org/r/649373

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 18 2020, 11:56 AM
gerritbot added a comment.Dec 18 2020, 1:12 PM

Change 648309 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Move WikibaseRepo constructor params to services

https://gerrit.wikimedia.org/r/648309

gerritbot added a comment.Dec 18 2020, 1:12 PM

Change 648310 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Update getEntitySourceDefinitions() calls

https://gerrit.wikimedia.org/r/648310

gerritbot added a comment.Dec 18 2020, 1:12 PM

Change 648311 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Update getSettings() calls

https://gerrit.wikimedia.org/r/648311

gerritbot added a comment.Dec 18 2020, 1:17 PM

Change 648312 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Update getSettings() calls

https://gerrit.wikimedia.org/r/648312

gerritbot added a comment.Dec 18 2020, 1:18 PM

Change 648315 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseMediaInfo@master] Update getEntitySourceDefinitions() calls

https://gerrit.wikimedia.org/r/648315

gerritbot added a comment.Dec 18 2020, 1:18 PM

Change 648316 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseMediaInfo@master] Update getSettings() calls

https://gerrit.wikimedia.org/r/648316

gerritbot added a comment.Dec 18 2020, 1:18 PM

Change 648313 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseCirrusSearch@master] Update getEntitySourceDefinitions() calls

https://gerrit.wikimedia.org/r/648313

gerritbot added a comment.Dec 18 2020, 1:18 PM

Change 648314 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseCirrusSearch@master] Update getSettings() calls

https://gerrit.wikimedia.org/r/648314

gerritbot added a comment.Dec 18 2020, 1:20 PM

Change 648317 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Update getEntitySourceDefinitions() calls

https://gerrit.wikimedia.org/r/648317

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 18 2020, 1:21 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 18 2020, 2:28 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 18 2020, 2:31 PM
gerritbot added a comment.Jan 4 2021, 12:21 PM

Change 648306 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] ItemHandlerTest, PropertyHandlerTest: override two methods

https://gerrit.wikimedia.org/r/648306

gerritbot added a comment.Jan 4 2021, 12:25 PM

Change 648307 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] LexemeHandlerTest: override two methods

https://gerrit.wikimedia.org/r/648307

Lucas_Werkmeister_WMDE mentioned this in rEWLC9c3a3fd714f8: LexemeHandlerTest: override two methods.Jan 4 2021, 12:34 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Jan 4 2021, 1:00 PM
gerritbot added a comment.Jan 5 2021, 9:44 AM

Change 648305 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] LexemeHandlerTest: override two methods

https://gerrit.wikimedia.org/r/648305

gerritbot added a comment.Jan 5 2021, 9:44 AM

Change 648308 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityHandlerTestCase: don’t call getHandler() from data providers

https://gerrit.wikimedia.org/r/648308

gerritbot added a comment.Jan 5 2021, 9:48 AM

Change 649373 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityHandlerTestCase: don’t hard-code item+property

https://gerrit.wikimedia.org/r/649373

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.26; 2021-01-12); removed MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Jan 5 2021, 10:01 AM
gerritbot added a comment.Jan 5 2021, 10:15 AM

Change 648309 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move WikibaseRepo constructor params to services

https://gerrit.wikimedia.org/r/648309

gerritbot added a comment.Jan 5 2021, 10:28 AM

Change 648317 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Update getEntitySourceDefinitions() calls

https://gerrit.wikimedia.org/r/648317

gerritbot added a comment.Jan 5 2021, 10:31 AM

Change 648312 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Update getSettings() calls

https://gerrit.wikimedia.org/r/648312

gerritbot added a comment.Jan 5 2021, 10:34 AM

Change 648315 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Update getEntitySourceDefinitions() calls

https://gerrit.wikimedia.org/r/648315

gerritbot added a comment.Jan 5 2021, 10:53 AM

Change 648316 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Update getSettings() calls

https://gerrit.wikimedia.org/r/648316

gerritbot added a comment.Jan 5 2021, 12:12 PM

Change 648310 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update getEntitySourceDefinitions() calls

https://gerrit.wikimedia.org/r/648310

gerritbot added a comment.Jan 5 2021, 12:14 PM

Change 648311 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update getSettings() calls

https://gerrit.wikimedia.org/r/648311

gerritbot added a comment.Jan 5 2021, 12:14 PM

Change 648313 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Update getEntitySourceDefinitions() calls

https://gerrit.wikimedia.org/r/648313

gerritbot added a comment.Jan 5 2021, 12:14 PM

Change 648314 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Update getSettings() calls

https://gerrit.wikimedia.org/r/648314

noarave moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 6 2021, 8:19 AM
WMDE-leszek closed this task as Resolved.Jan 6 2021, 12:31 PM
WMDE-leszek moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE mentioned this in Wikibase Service Migration.Feb 22 2021, 10:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL