Page MenuHomePhabricator
Create Task
Maniphest T270495

Wikisource Export: HTML entities like "&" rendered as "&" in ebook titles
Closed, ResolvedPublicBUG REPORT
Actions

Description

What is the problem?

Ampersands in book titles get rendered as &.

This bug was found by @Inductiveload in T270373#6698717.

Books to reproduce problem
Environment

Reproducible on wsexport production (commit 09565886c7f47e4dbbd1371d8935ab7882bb8382 16th Nov 2020)

Screenshots (if applicable):

Related Objects

Event Timeline

dom_walden created this task.Dec 18 2020, 2:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 18 2020, 2:56 PM
dom_walden mentioned this in T270373: Wikisource Export: Underscores show instead of spaces in some titles.Dec 18 2020, 2:57 PM
ifried moved this task from New & TBD Tickets to To Be Estimated/Discussed on the Community-Tech board.Dec 18 2020, 7:37 PM
Inductiveload added a comment.Dec 21 2020, 11:27 AM

Also " and other HTML entities.

Aklapper renamed this task from Wikisource Export: "&" rendered as "&" in ebook titles to Wikisource Export: HTML entities like "&" rendered as "&" in ebook titles.Dec 22 2020, 1:07 PM
dmaza added a subscriber: dmaza.Jan 5 2021, 10:44 PM

It seems that this is due to the way we sanitize the book & chapters' titles when generating the links. Possibly at https://github.com/wsexport/tool/blob/main/src/Cleaner/BookCleanerEpub.php#L166 ?

Samwilson claimed this task.Jan 14 2021, 7:57 AM
Samwilson edited projects, added Community-Tech (Kanban-2020-21-Q3); removed Community-Tech.
Samwilson moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q3) board.

I think I have a fix for this: https://github.com/wsexport/tool/pull/314

Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q3) board.Jan 14 2021, 10:23 PM
MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q3) board.Jan 18 2021, 5:40 PM
dom_walden moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (Kanban-2020-21-Q3) board.Jan 22 2021, 3:13 PM

&, ' and " now appear correctly on the title page.

This change appears to be on production.

Test environment: wsexport-test version 2.2.1-8-g9335af8.

ifried closed this task as Resolved.Jan 26 2021, 11:29 PM
ifried moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (Kanban-2020-21-Q3) board.
ifried added a subscriber: ifried.

As I have also seen in my tests, &, ' and " now appear correctly on the title page. I'm marking this as Done.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL