Page MenuHomePhabricator

Persistent storage maximum size reached
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

App version: 1.1.0

message
Persistent storage maximum size reached

Impact

Not sure, the app may freeze or crash

Notes

useArticleTextSize() is calling useLayoutEffect() often without any dependencies, which in turn is calling articleTextSize.init(), which manipulates the DOM and writes to local storage. This will run excessively often and causes memory issues and probably lag when reading articles in some cases.

Details

Request ID
undefined
Request URL
n/a
Stack Trace
exception.trace
set@app://kaios.wikipedia.org/dist/main.js:1:303746
adjust@app://kaios.wikipedia.org/dist/main.js:1:304044
init@app://kaios.wikipedia.org/dist/main.js:1:304359
useArticleTextSize/<@app://kaios.wikipedia.org/dist/main.js:1:404187
q@app://kaios.wikipedia.org/dist/main.js:1:307356
S.__c/</t.__h<@app://kaios.wikipedia.org/dist/main.js:1:309946
S.__c/<@app://kaios.wikipedia.org/dist/main.js:1:309907
S.__c@app://kaios.wikipedia.org/dist/main.js:1:309847
T@app://kaios.wikipedia.org/dist/main.js:1:291669
_/<@app://kaios.wikipedia.org/dist/main.js:1:287204
_@app://kaios.wikipedia.org/dist/main.js:1:287023

Event Timeline

AMuigai triaged this task as Medium priority.Dec 18 2020, 4:20 PM

FYI: the refactor I'm currently working on in T267293 will address the main issue here, thanks Stephane for flagging and creating this ticket

Refactor PR has been merged: https://github.com/wikimedia/wikipedia-kaios/pull/300

@Jpita I will move this ticket to the QA column, though I suspect the QA done for T267293 might suffice. For context, the refactor removes the useArticleTextSize hook completely, there is now no articleTextSize.init() that manipulates the DOM.

@SBisson I understand we have a board to keep track of production error tickets, maybe we should stick this one there?

@eamedina it's a query on the Q2 dashboard. It shows resolved production errors so they can eventually be verified in production. https://phabricator.wikimedia.org/project/4300/item/view/12452/