| • ppelberg | |
| Dec 19 2020, 1:22 AM |
| F34520294: file-1.jpg | |
| Jun 22 2021, 1:59 PM |
This task is about making it possible for people to easily reply to specific comments on mobile web talk pages and effortlessly follow social conventions in the process.
This work, will in large part, consist of adapting the UX of the Reply Tool to meet the need of people using talk pages on a mobile device.
TBD; @ppelberg to document the deployment timing here once it's been defined.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T233443 [Epic] Reply Tool | |||
| Resolved | None | T278588 Mobile talk page improvements | |||
| Resolved | None | T270536 Introduce the Reply Tool on mobile | |||
| Resolved | ovasileva | T276455 MobileFrontend transformations interfere with DiscussionTools transformations | |||
| Resolved | None | T282253 Design mobile Reply Tool UX | |||
| Duplicate | None | T294614 Mobile DiscussionTools' link inspector appears disconnected from the tools | |||
| Invalid | None | T294615 Mobile DiscussionTools' tools obfuscate text input area | |||
| Resolved | Jdlrobson | T295491 [beta] Minerva browser tests are broken on beta cluster since disabling the talk page overlay |
@Esanders put together a quick prototype to show how the Reply Tool, in its current, non-mobile-optimized state, would look and function on mobile: https://patchdemo.wmflabs.org/wikis/92f54aeb181032f8d810098631fae65f/w/index.php?title=Talk:Cat&mobileaction=toggle_view_mobile
Change 649726 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Support reply tool on mobile
Test wiki created on Patch Demo by Ed g2s using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/c1b86e55841e28175a3c37257b7f0c3f/w/
Updated link with some visual mode support: https://patchdemo.wmflabs.org/wikis/c1b86e55841e28175a3c37257b7f0c3f/w/index.php?title=Talk:Cat&mobileaction=toggle_view_mobile
Some reply links on the page still fail to open due to the way MobileFrontend changes the page.
For reference, we've merged a few patches recently with small interface fixes in preparation for this:
Almost everything seems to be working correctly in the latest version of the patch, with one exception – after posting a reply, page sections are no longer collapsible, and section edit links reload the page instead of immediately loading the editor.
Change 700221 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Reload the page after posting a comment on mobile
Status as of today, cc: @ppelberg
Here's a patchdemo we,ve just spun up with the full mobile-enabled and overlay-disabled set of patches: https://patchdemo.wmflabs.org/wikis/5fa616738b/wiki/Talk:Main_Page?useformat=mobile
https://www.figma.com/file/NreUF7q404NYuoMOPJGeWl/OWC-x--Work-in-Progress?node-id=1669%3A761
@ppelberg - Hi Peter, wanted to let you know that the team and I talked and we decided to go with option 1 of the two shown here: https://www.figma.com/file/NreUF7q404NYuoMOPJGeWl/OWC-x--Work-in-Progress?node-id=1669%3A761
Please let us know if you want to add anything to this decision.
Change 700958 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Adjust use of 'plainlinks' class to fix button styling on mobile
Change 702236 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix saving edit mode on mobile in reply tool
Next steps
@DLynch: can you please continue to treat the desktop empty state experience implementation as independent of the mobile empty state experience implementation? Said another way: I'd like make it so introducing the empty state experience does NOT depend on introducing the Reply Tool on mobile.
I've represented the decision above by filing T287805.
Change 700958 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Adjust use of 'plainlinks' class to fix button styling in some cases
Change 649726 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Support reply tool on mobile
Change 700221 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Reload the page after posting a comment on mobile
Change 702236 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix saving edit mode on mobile in reply tool
Change 736918 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[operations/mediawiki-config@master] Disable upcoming DiscussionTools mobile interface, enable on beta
Change 736918 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable upcoming DiscussionTools mobile interface, enable on beta
Mentioned in SAL (#wikimedia-operations) [2021-11-04T23:44:00Z] <cjming@deploy1002> Synchronized wmf-config: Config: [[gerrit:736918|Disable upcoming DiscussionTools mobile interface, enable on beta (T270536)]] (duration: 00m 55s)
Change 736862 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):
[mediawiki/extensions/DiscussionTools@master] Enable DiscussionTools mobile by default for ease of testing
Change 736862 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Enable DiscussionTools mobile by default for ease of testing
Explanation for the recent flurry of patches:
We've decided to add a configuration option for the mobile interface, and then disable it in the configuration for production Wikimedia wikis, but enable it by default in the source code.
This allows us to merge other patches that were blocked on this, and to test them on the beta cluster (after they're merged) or in Patch Demo wikis (before they're merged), without changing anything for the users until everything is ready to be deployed.
All that you described sounds great, @matmarex; I'm glad you decided to move forward with doing this.
Also, I value you posting the comment above; it relieved me of the questions I had about these "flurry of patches."
Test wiki on Patch Demo by ESanders (WMF) using patch(es) linked to this task was deleted:
https://patchdemo.wmflabs.org/wikis/c1b86e55841e28175a3c37257b7f0c3f/w/
Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted:
Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted:
This has been done as a part of T298060: [RELEASE TICKET] Offer Mobile DiscussionTools at All Wikis.
