Automatically populate the edit summary field
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	ppelberg
	Dec 19 2020, 2:09 AM

Description

This task is about making it so the New Discussion Tool's currently named [i] Comment summary field is automatically populated with the edit summary that will, by default, accompany edits posted with it.

@Patriccck noticed and reported this in https://www.mediawiki.org/wiki/Topic:Vztpon52zpb2tjf9.

Behavior

Open the New Discussion Tool
Write something in the Topic field
Show the Comment summary field by tapping the Advanced link

Actual
4.❗️Notice the Comment summary field is empty

Expected

✅Notice the Comment summary field contains the content you wrote in "Step 2." Note: anytime the contents of the Topic field are changed, the contents of the Comment summary field should change as well.

Done

"Expected" behavior is implemented

i. The name of this field will change as a result of the work happening in T264220

Related Objects
Search...

Status	Assigned	Task
Open	None	T276497 Scale DiscussionTools to all projects
Open	None	T251207 [Epic] Scale DiscussionTools to all Wikipedias
Open	None	T275256 Make New Discussion Tool available as opt-out feature at all wikis
Open	None	T271964 Make New Discussion Tool available as opt-out feature at partner wikis
		Restricted Task
Resolved	ppelberg	T275257 Offer New Discussion Tool as Beta Feature at all Wikipedias
Resolved	Ryasmeen	T275813 Post-deployment QA (New Discussion Tool)
Resolved	matmarex	T275827 Deploy config change to scale New Discussion Tool's availability as a beta feature
Resolved	Esanders	T275923 Pressing "cancel" on an empty new topic widget triggers the title validation and doesn't close the widget
Resolved	matmarex	T276967 Turn off Reply Tool A/B test
Resolved	Whatamidoing-WMF	T275828 Make volunteers aware of New Discussion Tool's availability as beta feature
Resolved	Whatamidoing-WMF	T275830 Verify integrity of New Discussion Tool edits at ar, cs and hu.wiki
Resolved	ppelberg	T273082 Offer Reply and New Discussion Tools as Beta Features at "Phase 4" Wikipedias.
Resolved	matmarex	T273146 Make the Reply and New Discussion Tools available as opt-in Beta Features at en.wiki
Resolved	Whatamidoing-WMF	T273147 Consult with volunteers at en.wiki about offering the Reply Tool as a Beta Feature
Resolved	Whatamidoing-WMF	T273233 Update en.wiki Talk pages project page
Resolved	matmarex	T276493 Make the Reply Tool and New Discussion Tools available as opt-in Beta Features at ru.wiki
Resolved	Whatamidoing-WMF	T275255 Consult with volunteers at ru.wiki about offering the Reply Tool as a Beta Feature
Resolved	matmarex	T276494 Make the Reply and New Discussion Tools available as Beta Features at de.wiki
Resolved	Whatamidoing-WMF	T275254 Consult with volunteers at de.wiki about offering the Reply Tool as a Beta Feature
Open	None	T277506 Enable New Discussion Tool as opt-out setting at office.wiki
Open	None	T277825 Analyze the impact of the New Discussion Tool
Open	None	T233446 [Epic] Affordance: Start a new discussion
Open	MNeisler	T263054 New Discussion Tool: calculate workflow engagement metrics
Resolved	ppelberg	T269471 Make New Discussion Tool available as Beta Feature at partner wikis
Invalid	None	T270539 Automatically populate the edit summary field

Event Timeline

ppelberg created this task.Dec 19 2020, 2:09 AM

ppelberg updated the task description. (Show Details)Dec 19 2020, 2:19 AM

ppelberg moved this task from Needs Discussion / Investigation to Ready to Be Worked On on the Editing-team (FY2020-21 Kanban Board) board.

ppelberg added a subscriber: Patriccck.

BEANS-X2 awarded a token.Dec 19 2020, 6:47 AM

This works correctly for me. When you open the "Advanced" drawer, the "Comment summary" field is pre-filled with: "/* Topic */ new section". When you change the "Topic" field, it is updated.

However, after you make any change to the "Comment summary" field, it will no longer be updated when you change the "Topic" field. In particular, if you delete the pre-filled text from the "Comment summary" field, it will stay empty. I think this is basically the correct behavior (the tool should not overwrite your input), but maybe the interface could make it more clear what is happening. Ideas would be welcome.

(Also, if you post the new topic with an empty "Comment summary" field, an automatic summary will be generated instead. This is technically a bug, since I didn't intend it to work that way, but it actually seems like a desirable behavior to me? Opinions on this would also be welcome.)

ppelberg updated the task description. (Show Details)Dec 24 2020, 12:27 AM

In T270539#6705052, @matmarex wrote:

This works correctly for me. When you open the "Advanced" drawer, the "Comment summary" field is pre-filled with: "/* Topic */ new section". When you change the "Topic" field, it is updated.

Huh. This is working for me now as well. I'm going to "Decline" this accordingly. We can reopen this task if it regresses.

However, after you make any change to the "Comment summary" field, it will no longer be updated when you change the "Topic" field. In particular, if you delete the pre-filled text from the "Comment summary" field, it will stay empty. I think this is basically the correct behavior (the tool should not overwrite your input),

Agreed.

...but maybe the interface could make it more clear what is happening. Ideas would be welcome.

Let's see if this proves to be an issue.

(Also, if you post the new topic with an empty "Comment summary" field, an automatic summary will be generated instead. This is technically a bug, since I didn't intend it to work that way, but it actually seems like a desirable behavior to me? Opinions on this would also be welcome.)

Hmm, automatically generating a summary seems to comply with convention while being inconsistent with the logic above. [i]

My instinct is for the EditSummaryField to respect (read: not overwrite) peoples' input in all cases. Thinking: I assume people will have an easier time understanding how the field works if the rules that govern its behavior are easy to intuit.

Either way, I think we can consider this in another ticket: T270800.

i."...the tool should not overwrite your input..."

ppelberg mentioned this in T270538: Remove the edit summary field from the new discussion tool.Jan 7 2021, 2:48 AM

Automatically populate the edit summary field Closed, InvalidPublicActions