Page MenuHomePhabricator

Automatically populate the edit summary field
Closed, InvalidPublic

Description

This task is about making it so the New Discussion Tool's currently named [i] Comment summary field is automatically populated with the edit summary that will, by default, accompany edits posted with it.

@Patriccck noticed and reported this in https://www.mediawiki.org/wiki/Topic:Vztpon52zpb2tjf9.

Behavior

  1. Open the New Discussion Tool
  2. Write something in the Topic field
  3. Show the Comment summary field by tapping the Advanced link

Actual
4.❗️Notice the Comment summary field is empty

Expected

  1. ✅Notice the Comment summary field contains the content you wrote in "Step 2." Note: anytime the contents of the Topic field are changed, the contents of the Comment summary field should change as well.

Done

  • "Expected" behavior is implemented

i. The name of this field will change as a result of the work happening in T264220

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedppelberg
ResolvedRyasmeen
Resolvedmatmarex
ResolvedEsanders
Resolvedmatmarex
ResolvedWhatamidoing-WMF
ResolvedWhatamidoing-WMF
Resolvedppelberg
Resolvedmatmarex
ResolvedWhatamidoing-WMF
ResolvedWhatamidoing-WMF
Resolvedmatmarex
ResolvedWhatamidoing-WMF
Resolvedmatmarex
ResolvedWhatamidoing-WMF
OpenNone
OpenNone
OpenNone
OpenMNeisler
Resolvedppelberg
InvalidNone

Event Timeline

This works correctly for me. When you open the "Advanced" drawer, the "Comment summary" field is pre-filled with: "/* Topic */ new section". When you change the "Topic" field, it is updated.

However, after you make any change to the "Comment summary" field, it will no longer be updated when you change the "Topic" field. In particular, if you delete the pre-filled text from the "Comment summary" field, it will stay empty. I think this is basically the correct behavior (the tool should not overwrite your input), but maybe the interface could make it more clear what is happening. Ideas would be welcome.

(Also, if you post the new topic with an empty "Comment summary" field, an automatic summary will be generated instead. This is technically a bug, since I didn't intend it to work that way, but it actually seems like a desirable behavior to me? Opinions on this would also be welcome.)

This works correctly for me. When you open the "Advanced" drawer, the "Comment summary" field is pre-filled with: "/* Topic */ new section". When you change the "Topic" field, it is updated.

Huh. This is working for me now as well. I'm going to "Decline" this accordingly. We can reopen this task if it regresses.

However, after you make any change to the "Comment summary" field, it will no longer be updated when you change the "Topic" field. In particular, if you delete the pre-filled text from the "Comment summary" field, it will stay empty. I think this is basically the correct behavior (the tool should not overwrite your input),

Agreed.

...but maybe the interface could make it more clear what is happening. Ideas would be welcome.

Let's see if this proves to be an issue.

(Also, if you post the new topic with an empty "Comment summary" field, an automatic summary will be generated instead. This is technically a bug, since I didn't intend it to work that way, but it actually seems like a desirable behavior to me? Opinions on this would also be welcome.)

Hmm, automatically generating a summary seems to comply with convention while being inconsistent with the logic above. [i]

My instinct is for the EditSummaryField to respect (read: not overwrite) peoples' input in all cases. Thinking: I assume people will have an easier time understanding how the field works if the rules that govern its behavior are easy to intuit.

Either way, I think we can consider this in another ticket: T270800.


i."...the tool should not overwrite your input..."