Page MenuHomePhabricator
Create Task
Maniphest T270539

Automatically populate the edit summary field
Closed, InvalidPublic
Actions

Description

This task is about making it so the New Discussion Tool's currently named [i] Comment summary field is automatically populated with the edit summary that will, by default, accompany edits posted with it.

@Patriccck noticed and reported this in https://www.mediawiki.org/wiki/Topic:Vztpon52zpb2tjf9.

Behavior

  1. Open the New Discussion Tool
  2. Write something in the Topic field
  3. Show the Comment summary field by tapping the Advanced link

Actual
4.❗️Notice the Comment summary field is empty

Expected

  1. ✅Notice the Comment summary field contains the content you wrote in "Step 2." Note: anytime the contents of the Topic field are changed, the contents of the Comment summary field should change as well.

Done

  • "Expected" behavior is implemented

i. The name of this field will change as a result of the work happening in T264220

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT276497 Scale DiscussionTools to all projects
 OpenNoneT251207 [Epic] Scale DiscussionTools to all Wikipedias
 OpenNoneT233446 [Epic] New Discussion Tool
 OpenNoneT275256 Make New Topic Tool (desktop) available as opt-out feature at all wikis
 Resolved• LZamanT271964 [Release ticket] Make New Discussion Tool available as opt-out feature at partner wikis
 ResolvedppelbergT269471 Make New Discussion Tool available as Beta Feature at partner wikis
 InvalidNoneT270539 Automatically populate the edit summary field
Restricted Task
 ResolvedppelbergT275257 Offer New Discussion Tool as Beta Feature at all Wikipedias
 ResolvedRyasmeenT275813 Post-deployment QA (New Discussion Tool)
 ResolvedmatmarexT275827 Deploy config change to scale New Discussion Tool's availability as a beta feature
 ResolvedEsandersT275923 Pressing "cancel" on an empty new topic widget triggers the title validation and doesn't close the widget
 ResolvedmatmarexT276967 Turn off Reply Tool A/B test
 ResolvedWhatamidoing-WMFT275828 Make volunteers aware of New Discussion Tool's availability as beta feature
 ResolvedWhatamidoing-WMFT275830 Verify integrity of New Discussion Tool edits at ar, cs and hu.wiki
 ResolvedppelbergT273082 Offer Reply and New Discussion Tools as Beta Features at "Phase 4" Wikipedias.
 ResolvedmatmarexT273146 Make the Reply and New Discussion Tools available as opt-in Beta Features at en.wiki
 ResolvedWhatamidoing-WMFT273147 Consult with volunteers at en.wiki about offering the Reply Tool as a Beta Feature
 ResolvedWhatamidoing-WMFT273233 Update en.wiki Talk pages project page
 ResolvedmatmarexT276493 Make the Reply Tool and New Discussion Tools available as opt-in Beta Features at ru.wiki
 ResolvedWhatamidoing-WMFT275255 Consult with volunteers at ru.wiki about offering the Reply Tool as a Beta Feature
 ResolvedmatmarexT276494 Make the Reply and New Discussion Tools available as Beta Features at de.wiki
 ResolvedWhatamidoing-WMFT275254 Consult with volunteers at de.wiki about offering the Reply Tool as a Beta Feature
 DuplicateNoneT277506 Enable New Discussion Tool as opt-out setting at office.wiki
 DeclinedMNeislerT263054 New Discussion Tool: calculate workflow engagement metrics
OpenNoneT285117 Add support for the InputBox extension
 OpenmatmarexT269310 Add support for preloaded text
ResolvedRyasmeenT269033 Add edit notice element to New Discussion Tool
 ResolvedppelbergT270454 Implement edit notice logic
 ResolvedEsandersT272188 VE API: Return structured information about edit notices so they can be filtered by clients
 OpenNoneT272656 Solicit feedback from page maintainers about preload opt-in approach
 OpenNoneT270797 Create way for individual pages to opt-in to using the New Discussion Tool for preloads
 ResolvedppelbergT274746 Create an easy way to link people to an open New Discussion Tool
 ResolvedppelbergT282204 Handle URLs for starting new sections
 OpenWhatamidoing-WMFT287804 Create deployment plan for scaling New Topic Tool as opt-out at all projects
 ResolvedmatmarexT287901 Revise empty Title field warning message display logic
 ResolvedmatmarexT288319 "Start a discussion" empty state message should not appear on empty talk pages when corresponding page (or user) doesn't exist
 ResolvedppelbergT290517 [Release Ticket] Introduce New Topic Tool (desktop) as opt-out at A/B test wikis
 ResolvedmpopovT277825 Run A/B test to evaluate impact of New Topic Tool
 ResolvedMNeislerT290204 [SPIKE] Estimate New Discussion Tool A/B Test Feasibility
 ResolvedDLynchT291308 Make config change to start New Discussion Tool A/B Test
 ResolvedWhatamidoing-WMFT291306 Identify wikis for New Discussion Tool A/B test
 ResolvedRyasmeenT291307 Implement New Discussion Tool A/B test bucketing
 ResolvedppelbergT291536 [SPIKE] How can we ensure that we are able to identify and distinguish prior users of the New Discussion Tool in the AB test?
 ResolvedppelbergT292120 [SPIKE] Determine how we can identify blocked save attempts
 ResolvedDLynchT293962 Introduce a "hint" that informs people how they can enable the legacy section=new experience
 ResolvedppelbergT294491 [SPIKE] How many people have turned off the New Discussion Tool since it's been available as a Beta Feature
 ResolvedDLynchT294167 Implement way to identify people who have opened the New Discussion Tool before
 ResolvedppelbergT297847 Ensure New Discussion Tool Hint Is Fully Translated
 ResolvedppelbergT301496 Add distinct event to talk_page_edit for when a new section is added
 ResolvedmatmarexT288741 Talk Page Empty State: write English copy for translation
 ResolvedBUG REPORTmatmarexT291085 redlink=1 not respected in zhwiki
 ResolvedppelbergT291535 Inform participating wikis of start of New Discussion Tool A/B Test
 ResolvedDLynchT291873 Deploy config change to "turn off" New Discussion Tool A/B test
 ResolvedWhatamidoing-WMFT295098 [SPIKE] What – if any – reactions have people had to the start of the New Discussion Tool A/B test?
 ResolvedppelbergT297714 [SPIKE] What is the makeup of people who have adjusted the state of the Discussion tools beta feature?
 ResolvedSpikeMNeislerT301495 [SPIKE] Investigate what init type is associated with the sessions where a ready event is being emitted, but an anonymous user token is not being logged
 ResolvedppelbergT301497 Ensure the A/B test bucket is logged when a logged out user edits a full page in wikitext
 ResolvedDLynchT301499 [SPIKE] What could be causing a ready event to be emitted, but an anonymous user token NOT to be logged
 ResolvedWhatamidoing-WMFT304658 Announce New Topic Tool A/B test findings to wikis participating in test
 ResolvedppelbergT306481 Add more granular experience level buckets to New Topic Tool A/B test report
 DeclinedMNeislerT306579 Investigate rate at which Senior Contributors abandon New Topic Tool edits
ResolvedDLynchT307410 [Config Change] Enable the New Topic Tool as opt-out at A/B test wikis
 OpenNoneT295097 [Communications] Ensure Senior Contributors are aware of the New Discussion Tool being made available as opt-out
ResolvedppelbergT309368 [Config Change] Enable New Topic Tool as opt-out at Phase 3 wikis (desktop)
 OpenNoneT309369 Inform volunteers at Phase 3 wikis of upcoming New Topic Tool (desktop) deployment
 ResolvedmatmarexT297990 Clarify how the "Enable quick topic adding" setting affects creating new talk pages (separate setting?)
 ResolvedmatmarexT310392 [Config Change] Enable New Topic Tool as opt-out at Phase 4 wikis (desktop)
 ResolvedEpicPupperT297974 "Title" is unclear, and should probably say "Subject" or "Topic" instead
 OpenNoneT310215 Some English Wikipedia templates with signatures in the middle don't work well with reply and new topic tool
 ResolvedmatmarexT311023 Enable new topic tool by default on enwiki
 ResolvedRyasmeenT313699 [Config Change] Enable New Topic Tool as opt-out at de.wiki (desktop)

Event Timeline

ppelberg created this task.Dec 19 2020, 2:09 AM
ppelberg updated the task description. (Show Details)Dec 19 2020, 2:19 AM
ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.
ppelberg added a subscriber: Patriccck.
BEANS-X2 awarded a token.Dec 19 2020, 6:47 AM
matmarex added a comment.Dec 20 2020, 7:28 PM

This works correctly for me. When you open the "Advanced" drawer, the "Comment summary" field is pre-filled with: "/* Topic */ new section". When you change the "Topic" field, it is updated.

However, after you make any change to the "Comment summary" field, it will no longer be updated when you change the "Topic" field. In particular, if you delete the pre-filled text from the "Comment summary" field, it will stay empty. I think this is basically the correct behavior (the tool should not overwrite your input), but maybe the interface could make it more clear what is happening. Ideas would be welcome.

(Also, if you post the new topic with an empty "Comment summary" field, an automatic summary will be generated instead. This is technically a bug, since I didn't intend it to work that way, but it actually seems like a desirable behavior to me? Opinions on this would also be welcome.)

ppelberg updated the task description. (Show Details)Dec 24 2020, 12:27 AM
ppelberg closed this task as Invalid.Dec 24 2020, 12:46 AM
ppelberg mentioned this in T270800: Define how edit summaries should behave when the summary field is "blanked" within the New Discussion Tool.
In T270539#6705052, @matmarex wrote:

This works correctly for me. When you open the "Advanced" drawer, the "Comment summary" field is pre-filled with: "/* Topic */ new section". When you change the "Topic" field, it is updated.

Huh. This is working for me now as well. I'm going to "Decline" this accordingly. We can reopen this task if it regresses.

However, after you make any change to the "Comment summary" field, it will no longer be updated when you change the "Topic" field. In particular, if you delete the pre-filled text from the "Comment summary" field, it will stay empty. I think this is basically the correct behavior (the tool should not overwrite your input),

Agreed.

...but maybe the interface could make it more clear what is happening. Ideas would be welcome.

Let's see if this proves to be an issue.

(Also, if you post the new topic with an empty "Comment summary" field, an automatic summary will be generated instead. This is technically a bug, since I didn't intend it to work that way, but it actually seems like a desirable behavior to me? Opinions on this would also be welcome.)

Hmm, automatically generating a summary seems to comply with convention while being inconsistent with the logic above. [i]

My instinct is for the EditSummaryField to respect (read: not overwrite) peoples' input in all cases. Thinking: I assume people will have an easier time understanding how the field works if the rules that govern its behavior are easy to intuit.

Either way, I think we can consider this in another ticket: T270800.

i."...the tool should not overwrite your input..."

ppelberg mentioned this in T270538: Remove the edit summary field from the new discussion tool.Jan 7 2021, 2:48 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL