Page MenuHomePhabricator

Clean up Pingback (decouple for DI, document, add test coverage)
Closed, ResolvedPublic

Description

This hasn't been touched in a while. It's a fairly simple and well-isolated component that consists of only a single class.

As part of T269516#6702070, I made some improvements to it, after which I cleaned it up a bit.

This task is to track:

  • Knowledge transfer about this class, and to sync up on best practices more generally (it makes for an easy demo case).
  • Code review of the decoupling, documentatioon, and added test coverage.

The Pingback component is an EventLogging instrument that powers https://pingback.wmflabs.org/ which helps WMF understand how MediaWiki is used in the wild in terms of PHP, web server, and database support, etc.

Event Timeline

Krinkle created this task.Dec 19 2020, 3:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2020, 3:25 AM

Change 650641 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] Pingback: Re-order methods prior to refactor

https://gerrit.wikimedia.org/r/650641

Change 650642 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] Pingback: Refactor for dependency injection and cover with tests

https://gerrit.wikimedia.org/r/650642

Change 650643 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] Pingback: Don't instantiate service if disabled by configuration

https://gerrit.wikimedia.org/r/650643

Prod added a subscriber: Prod.Dec 19 2020, 3:48 AM

Change 650641 merged by jenkins-bot:
[mediawiki/core@master] Pingback: Re-order methods prior to refactor

https://gerrit.wikimedia.org/r/650641

Change 650642 merged by jenkins-bot:
[mediawiki/core@master] Pingback: Refactor for dependency injection and cover with tests

https://gerrit.wikimedia.org/r/650642

Change 650643 merged by jenkins-bot:
[mediawiki/core@master] Pingback: Don't instantiate service if disabled by configuration

https://gerrit.wikimedia.org/r/650643

Is this complete?

nnikkhoui closed this task as Resolved.Dec 23 2020, 7:19 PM
nnikkhoui claimed this task.

I believe so, all 3 patches were merged and we did a short knowledge transfer.

nnikkhoui reassigned this task from nnikkhoui to Krinkle.Dec 23 2020, 7:20 PM