DatabaseBlockStore::updateBlock should accept IDatabase as a parameter
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Urbanecm
	Dec 19 2020, 7:29 PM

Description

So we can do crosswiki blocks (for instance, CentralAuth uses this feature).

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Make DatabaseBlockStore::updateBlock to accept IDatabase as a parameter	mediawiki/core	master	+3 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	BUG REPORT	None	T25310 Global suppression does not work properly when the target has already been locally blocked
Open		None	T270558 Make it possible to inject IDatabase into BlockUser
Declined		None	T270559 DatabaseBlockStore::updateBlock should accept IDatabase as a parameter

Event Timeline

Urbanecm created this task.Dec 19 2020, 7:29 PM

Restricted Application added a project: User-Urbanecm. · View Herald TranscriptDec 19 2020, 7:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 650820 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Make DatabaseBlockStore::updateBlock to accept IDatabase as a parameter

https://gerrit.wikimedia.org/r/650820

gerritbot added a project: Patch-For-Review.Dec 19 2020, 7:31 PM

Urbanecm mentioned this in T25310: Global suppression does not work properly when the target has already been locally blocked.Dec 19 2020, 7:32 PM

Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.

Urbanecm triaged this task as Low priority.Dec 20 2020, 8:46 AM

I created now T291849: Create a DatabaseBlockStoreFactory in order to make DatabaseBlockStore a proper cross-wiki store, which is imo a cleaner solution than this.

phuedx moved this task from Untriaged to MediaWiki-Blocks on the Anti-Harassment-Team board.Oct 18 2021, 4:21 PM

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Feb 21 2023, 9:32 PM

@Urbanecm: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on Feburary 22nd, 2023.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Let's do T291849 instead.

Change 650820 abandoned by Urbanecm:

[mediawiki/core@master] Make DatabaseBlockStore::updateBlock to accept IDatabase as a parameter

Reason: