Page MenuHomePhabricator

Update league/oauth2-server fork, and update in MW Vendor
Closed, ResolvedPublic

Description

As a fix for T270588: OAuth 2.0 error on PHP 7.4, I'm bumping league/oauth2-server (8.1.0 => 8.2.4) in MW-1.35-release

This brings in PHP 8.0 support, also fixing PHP 7.4 log noise...

But this will mean our fork (which AFAIK is based on 8.1.0?) will be behind REL1_35, which is a bit meh

I don't think this is a blocker for T245757: Upgrade MediaWiki clusters to Debian Buster (debian 10), as we're "only" going to PHP 7.3 (eventually, AIUI), but it'd be nice to keep these thing in sync, and not get caught out by it again later

Event Timeline

Reedy renamed this task from Update league/oauth2-server fork to Update league/oauth2-server fork, and update in MW Vendor.Dec 20 2020, 4:19 PM
Reedy added a project: MediaWiki-Vendor.

I don't think this is a blocker for T245757: Upgrade MediaWiki clusters to Debian Buster (debian 10), as we're "only" going to PHP 7.3 (AIUI), but it'd be nice to keep these thing in sync, and not get caught out by it again later

Initially we're staying on our special blend of 7.2.

I've pushed updated master and the recent tags to https://github.com/wikimedia/oauth2-server

$ git push origin HEAD:master
Total 0 (delta 0), reused 0 (delta 0)
To github.com:wikimedia/oauth2-server.git
   340d1ab7..15abf4ab  HEAD -> master
$ git push --tags
Total 0 (delta 0), reused 0 (delta 0)
To github.com:wikimedia/oauth2-server.git
 * [new tag]           8.2.0 -> 8.2.0
 * [new tag]           8.2.1 -> 8.2.1
 * [new tag]           8.2.2 -> 8.2.2
 * [new tag]           8.2.3 -> 8.2.3
 * [new tag]           8.2.4 -> 8.2.4

What's the status here? Is review still needed? Of what, by whom?

@Clarakosi I see you did https://github.com/wikimedia/oauth2-server/commits/update_v9.0.0-alpha... Is that actually ready to go? :)

Almost? :) It still needs review.

Moving it to the review column. PR: https://github.com/wikimedia/oauth2-server/pull/2

^

I guess by platform, as your team made the fork in the first place...

I've reviewed and approved the changes.

I've reviewed and approved the changes.

Just needs someone to merge them then :)

And then update in MediaWiki-Vendor

Change 668578 had a related patch set uploaded (by Clarakosi; owner: Clarakosi):
[mediawiki/vendor@master] Update oauth2-server and lcobucci/jwt to v3.4.0

https://gerrit.wikimedia.org/r/668578

Change 668578 merged by jenkins-bot:
[mediawiki/vendor@master] Update oauth2-server and lcobucci/jwt

https://gerrit.wikimedia.org/r/668578

Reedy assigned this task to Clarakosi.

Thanks!