Stop accessing global config variables from SecurePoll maintenance scripts
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	Dec 21 2020, 7:27 PM

Description

See T71084 for the motivation behind this work.

Classes that extend Maintenance can access configs using Maintenance::getConfig rather than accessing the global config variables.

Example from DumpGlobalVoterList:

global $wgLocalDatabases;
$wikis = $wgLocalDatabases;

can be replaced with:

$wikis = $this->getConfig()->get( 'LocalDatabases' );

Variables that should be replaced:

Class	global variable name
PurgePrivateVoteData	$wgSecurePollKeepPrivateInfoDays
DumpGlobalVoterList	$wgLocalDatabases

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Prefer Maintenance::getConfig over global variables	mediawiki/extensions/SecurePoll	master	+2 -6

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
In Progress	Mimurawil	T270646 Use Config instead of globals in SecurePoll extension
Resolved	STran	T270641 Stop accessing global config variables from SecurePoll maintenance scripts

Event Timeline

Tchanders created this task.Dec 21 2020, 7:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 21 2020, 7:27 PM

Tchanders updated the task description. (Show Details)Dec 21 2020, 7:28 PM

Tchanders added a parent task: T270646: Use Config instead of globals in SecurePoll extension.Dec 21 2020, 7:57 PM

Tchanders moved this task from Onboarding Tasks to Cards ready for development on the Anti-Harassment-Team board.Dec 22 2020, 7:13 PM

STran claimed this task.Dec 24 2020, 12:10 AM

STran moved this task from Cards ready for development to The Letter Song on the Anti-Harassment-Team board.

STran edited projects, added Anti-Harassment-Team (The Letter Song); removed Anti-Harassment-Team.

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.

Change 654314 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/extensions/SecurePoll@master] Prefer Maintenance::getConfig over global variables

https://gerrit.wikimedia.org/r/654314

gerritbot added a project: Patch-For-Review.Jan 4 2021, 9:57 PM

Change 654314 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Prefer Maintenance::getConfig over global variables

https://gerrit.wikimedia.org/r/654314

Tchanders moved this task from In Progress 💪 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment-Team (The Letter Song) board.Jan 5 2021, 2:43 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 5 2021, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2021, 3:10 PM

Niharika moved this task from Done: Q2 (2020-2021) ✅ to Done: Q3 (2020-2021) on the Anti-Harassment-Team (The Letter Song) board.Jan 6 2021, 7:29 PM

Niharika closed this task as Resolved.Jan 25 2021, 10:44 PM