See T71084 for the motivation behind this work.
Classes that extend ActionPage can access configs using SpecialPage::getConfig.
Example from VoterEligibilityPage:
global $wgSecurePollUseNamespace;
...
if ( global $wgSecurePollUseNamespace ) {
...can be replaced with:
if ( $this->specialPage->getConfig()->get('SecurePollUseNamespace') ) {
...ActionPage classes that access global config variables:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Remove Global Vars from ActionPages | Wikitrent | mediawiki/extensions/SecurePoll | master | +13 -32 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | TTO | T16264 Import sources should be maintained by stewards | |||
| Resolved | None | T46294 MWException error - Error: invalid magic word 'speciale' | |||
| Open | Feature | None | T28992 Implement configuration database aka configuration management aka no shell excuse | ||
| Open | None | T11968 Reduce use of global and public variables | |||
| Open | None | T294739 remove configuration access via global variables in core | |||
| Open | None | T71084 Convert things to use Config classes instead of globals | |||
| In Progress | Mimurawil | T270646 Use Config instead of globals in SecurePoll extension | |||
| Resolved | • wikitrent | T270644 Stop accessing global config variables from SecurePoll ActionPages (OT) |
Change 655751 had a related patch set uploaded (by Wikitrent; owner: Wikitrent):
[mediawiki/extensions/SecurePoll@master] Remove Global Vars from ActionPages
Change 655751 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Remove Global Vars from ActionPages