Maniphest T270646

Use Config instead of globals in SecurePoll extension
Open, In Progress, Needs TriagePublic
Actions

Assigned To

Authored By

	Tchanders
	Dec 21 2020, 7:56 PM

Tags

Referenced Files

	F63916352: image.png
	Jul 11 2025, 1:36 PM

Subscribers

Description

See parent task T11968 for details.

Classes that extend classes that have a method for accessing Config are straightforward to fix.

Other cases might need more work.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use config instead of globals	mediawiki/extensions/SecurePoll	master	+77 -45

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		TTO	T16264 Import sources should be maintained by stewards
		Resolved		None	T46294 MWException error - Error: invalid magic word 'speciale'
		Open	Feature	None	T28992 Implement configuration database aka configuration management aka no shell excuse
		Open		None	T11968 Reduce use of global and public variables
		Open		None	T294739 remove configuration access via global variables in core
		Open		None	T71084 Convert things to use Config classes instead of globals
		In Progress		Mimurawil	T270646 Use Config instead of globals in SecurePoll extension
		Resolved		AdhamKhatean	T270645 Stop accessing global config variables from SecurePoll's ListPager (OT)
		Resolved	Jan 12 2021	• wikitrent	T270644 Stop accessing global config variables from SecurePoll ActionPages (OT)
		Resolved	Jan 12 2021	• wikitrent	T270642 Stop accessing global config variable from SpecialSecurePoll (OT)
		Resolved		STran	T270641 Stop accessing global config variables from SecurePoll maintenance scripts

Event Timeline

Tchanders created this task.Dec 21 2020, 7:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 21 2020, 7:56 PM

Tchanders added a parent task: T11968: Reduce use of global and public variables.Dec 21 2020, 7:56 PM

Tchanders added subtasks: T270645: Stop accessing global config variables from SecurePoll's ListPager (OT), T270644: Stop accessing global config variables from SecurePoll ActionPages (OT), T270642: Stop accessing global config variable from SpecialSecurePoll (OT), T270641: Stop accessing global config variables from SecurePoll maintenance scripts.

Niharika closed subtask T270641: Stop accessing global config variables from SecurePoll maintenance scripts as Resolved.Jan 25 2021, 10:44 PM

Niharika closed subtask T270644: Stop accessing global config variables from SecurePoll ActionPages (OT) as Resolved.Jan 26 2021, 5:09 PM

Niharika closed subtask T270645: Stop accessing global config variables from SecurePoll's ListPager (OT) as Resolved.Feb 8 2021, 12:09 PM

Niharika closed subtask T270642: Stop accessing global config variable from SpecialSecurePoll (OT) as Resolved.Feb 8 2021, 12:40 PM

jrbs moved this task from Backlog to Needs evaluation on the MediaWiki-extensions-SecurePoll board.Sep 23 2022, 10:34 PM

kostajh moved this task from Needs evaluation to Ready for development on the MediaWiki-extensions-SecurePoll board.Jan 28 2025, 8:02 PM

Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptJan 28 2025, 8:02 PM

Mimurawil changed the task status from Open to In Progress.Feb 3 2025, 6:13 PM

Mimurawil claimed this task.

Mimurawil moved this task from Ready for development to Actively working on the MediaWiki-extensions-SecurePoll board.

Change #1117294 had a related patch set uploaded (by Mimurawil; author: Mimurawil):

[mediawiki/extensions/SecurePoll@master] Use config instead of globals

https://gerrit.wikimedia.org/r/1117294

gerritbot added a project: Patch-For-Review.Feb 5 2025, 1:03 AM

I found 3 occurrences I believe it may be okay to leave as global usages (treating them as exceptions).

Using global $wgConf (3 different files)
- Found in VotePage.php, FormStore.php, and RemoteMWAuth.php
- Even though $wgConf is an instance of MediaWiki\Config\SiteConfiguration, it's not exposed as a service - so it's not possible to access it via config

Change #1117294 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Use config instead of globals

https://gerrit.wikimedia.org/r/1117294

Maintenance_bot removed a project: Patch-For-Review.Feb 10 2025, 4:31 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.16; 2025-02-11).Feb 10 2025, 5:00 PM

I see 4 PHP "global" keywords left in the repo:

image.png (654×477 px, 38 KB)

Dreamy_Jazz edited projects, added Product Safety and Integrity; removed Trust and Safety Product Team.Feb 24 2026, 3:37 PM

Dreamy_Jazz moved this task from Inbox to Triaged (backlog) on the Product Safety and Integrity board.Feb 24 2026, 4:13 PM

MGChecker edited parent tasks, added: T71084: Convert things to use Config classes instead of globals; removed: T11968: Reduce use of global and public variables.Mar 26 2026, 4:48 PM