Page MenuHomePhabricator
Create Task
Maniphest T270684

Determine if wmf_reports is used by anyone & possibly remove
Closed, ResolvedPublic
Actions

Description

I suspect no one uses it - if they do it will be Pats or Major Gifts - actually I think the GatewayReconciliation report is the one Pats uses so probably move it

Details

SubjectRepoBranchLines +/-
Fully remove wmf_reportswikimedia/fundraising/crmmaster+0 -654
Remove WMF_lybunt reportwikimedia/fundraising/crmmaster+0 -20
Remove pseudo-bao from gateway reconcilliationwikimedia/fundraising/crmmaster+0 -29
Remove attempt to add Contacts & Contributions exportwikimedia/fundraising/crmmaster+0 -1 K
Remove ContributionTrends reportwikimedia/fundraising/crmmaster+0 -216
Remove old manual scripts from wmf_reportswikimedia/fundraising/crmmaster+0 -636
Customize query in gerrit

Related Objects
Search...

Event Timeline

Eileenmcnaughton created this task.Dec 22 2020, 2:04 AM
Eileenmcnaughton added subscribers: NNichols, • LeanneS, RLewis.Dec 22 2020, 2:13 AM

@LeanneS @NNichols @RLewis there are 2 lybunt report templates - one written for wmf here civicrm/report/contribute/wmf_lybunt?reset=1 and one which I did some work on for in core a few years back here
civicrm/report/contribute/lybunt?reset=1

My impression is you only use the second one now & the first one can go - are you able to confirm at all?

gerritbot added a comment.Dec 22 2020, 4:37 AM

Change 651308 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@master] Remove old manual scripts from wmf_reports

https://gerrit.wikimedia.org/r/651308

gerritbot added a project: Patch-For-Review.Dec 22 2020, 4:37 AM

Change 651309 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@master] Remove ContributionTrends report

https://gerrit.wikimedia.org/r/651309

gerritbot added a comment.Dec 22 2020, 4:50 AM

Change 651311 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@master] Remove attempt to add Contacts & Contributions export

https://gerrit.wikimedia.org/r/651311

RLewis added a comment.Dec 22 2020, 8:16 AM

@Eileenmcnaughton checking with Virtue too as I know she used to use these LYBUNT reports also.

gerritbot added a comment.Dec 22 2020, 3:50 PM

Change 651308 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Remove old manual scripts from wmf_reports

https://gerrit.wikimedia.org/r/651308

• DStrine added a project: Fr-drupal-upgrade-2021.Dec 22 2020, 7:27 PM
gerritbot added a comment.Dec 22 2020, 8:43 PM

Change 651309 merged by Eileen:
[wikimedia/fundraising/crm@master] Remove ContributionTrends report

https://gerrit.wikimedia.org/r/651309

Eileenmcnaughton added a project: Fundraising Sprint Zeitgeistbusters.Dec 22 2020, 11:18 PM
gerritbot added a comment.Dec 23 2020, 3:19 AM

Change 651676 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@master] Remove pseudo-bao from gateway reconcilliation

https://gerrit.wikimedia.org/r/651676

gerritbot added a comment.Dec 23 2020, 4:06 AM

Change 651311 merged by Eileen:
[wikimedia/fundraising/crm@master] Remove attempt to add Contacts & Contributions export

https://gerrit.wikimedia.org/r/651311

Eileenmcnaughton added a comment.Dec 23 2020, 4:27 AM

I have removed most of the code in this extension after analysis. What remains is

Eileenmcnaughton moved this task from Backlog to Review on the Fundraising Sprint Zeitgeistbusters board.Dec 23 2020, 4:28 AM
• DStrine added a subscriber: EMartin.Dec 23 2020, 4:45 PM

Gateway reconciliation is probably still used by @EMartin

@NNichols @RLewis would know if lybunt is used. But I'm pretty sure it still is.

For context for everyone I just looped in. We are moving around where some of these functions live in preparation to upgrade a system. If they aren't used we'd just shut them down. But I'm pretty sure they are used.

EMartin added a comment.Dec 23 2020, 5:16 PM

Confirming that I do indeed use the Gateway recon report. Please do not delete. Thank you:

image.png (293×698 px, 42 KB)

Eileenmcnaughton added a comment.Dec 23 2020, 8:06 PM

Re the Lybunt report - there are 2 lybunt reports- check the comment here https://phabricator.wikimedia.org/T270684#6707404 for the links to them. One is in core & the other is a custom WMF one that I believe is unused

Eileenmcnaughton claimed this task.Dec 28 2020, 8:49 PM
RLewis added a comment.Dec 29 2020, 10:13 AM

@Eileenmcnaughton and @NNichols I checked with Caitlin Virtue and she said the only way she would use this if there was a dashlet for it, @NNichols do you know if there is? If there isn't then I think we're good to shut down.

• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Jan 3 2021, 7:57 PM
• DStrine added a project: Fundraising Sprint Airline Passenger Experience.Jan 5 2021, 10:00 PM
• DStrine triaged this task as Low priority.Jan 5 2021, 10:12 PM
Eileenmcnaughton moved this task from Backlog to Doing on the Fundraising Sprint Airline Passenger Experience board.Jan 7 2021, 6:29 AM
• DStrine moved this task from Current Sprint to Sprint +2 on the Fundraising-Backlog board.Jan 19 2021, 8:51 PM
• DStrine moved this task from Sprint +2 to Sprint +3 on the Fundraising-Backlog board.Jan 19 2021, 9:18 PM
gerritbot added a comment.Feb 16 2021, 5:44 PM

Change 651676 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Remove pseudo-bao from gateway reconcilliation

https://gerrit.wikimedia.org/r/651676

Maintenance_bot removed a project: Patch-For-Review.Feb 16 2021, 6:10 PM
• DStrine moved this task from Sprint +3 to Sprint +1 on the Fundraising-Backlog board.Mar 30 2021, 12:07 AM
• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Mar 30 2021, 8:14 PM
• DStrine added a project: Fundraising Sprint Git Rebase Jump.Mar 30 2021, 8:28 PM
Eileenmcnaughton moved this task from Backlog to Doing on the Fundraising Sprint Git Rebase Jump board.Mar 30 2021, 8:42 PM
gerritbot added a comment.Mar 30 2021, 8:53 PM

Change 675906 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove WMF_lybunt report

https://gerrit.wikimedia.org/r/675906

gerritbot added a project: Patch-For-Review.Mar 30 2021, 8:53 PM
gerritbot added a comment.Mar 30 2021, 8:56 PM

Change 675908 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Stop installing wmf_reports

https://gerrit.wikimedia.org/r/675908

gerritbot added a comment.Mar 31 2021, 5:37 PM

Change 675906 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove WMF_lybunt report

https://gerrit.wikimedia.org/r/675906

Eileenmcnaughton moved this task from Doing to Pending Deployment on the Fundraising Sprint Git Rebase Jump board.Mar 31 2021, 11:49 PM
Eileenmcnaughton moved this task from Pending Deployment to Review on the Fundraising Sprint Git Rebase Jump board.
gerritbot added a comment.Apr 1 2021, 1:11 AM

Change 675908 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Fully remove wmf_reports

https://gerrit.wikimedia.org/r/675908

Eileenmcnaughton closed this task as Resolved.Apr 6 2021, 2:18 AM
Eileenmcnaughton moved this task from Review to Done on the Fundraising Sprint Git Rebase Jump board.

The module is no more

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL