Page MenuHomePhabricator

Ensure the New Discussion Tool defaults to the correct text input mode
Closed, DuplicatePublic

Description

This task is about ensuring the New Discussion Tool opens to the text input mode people and wikis expect, described in the ===Text input mode configuration section below.

Text input mode configuration

Account statusWiki configurationUser's editing mode preferenceUser edit countNew Discussion Tool text input defaultNotes
Logged intwo edit tabsno preference set≥1Last Reply Tool text input mode used. If none/empty, last article editor used
Logged intwo edit tabsno preference set0follow behavior defined in getPreferredEditorThis means visual on all wikis except: en.wikipedia, es.wikipedia, he.wikipedia and fr.wikitionary
Logged inN/Avisual≥0visual
Logged inN/Asource≥0source
Logged inN/AShow me both editor tabs0follow behavior defined in getPreferredEditorThis means visual on all wikis except: en.wikipedia, es.wikipedia, he.wikipedia and fr.wikitionary
Logged inN/Avisual≥0visual
Logged inN/AShow me both editor tabs≥1Last Reply Tool text input mode used. If none/empty, last article editor used
Logged outtwo edit tabsN/AN/Afollow behavior defined in getPreferredEditorThis means visual on all wikis except: en.wikipedia, es.wikipedia, he.wikipedia and fr.wikitionary
Logged outdefault visualN/AN/Ashow visual
Logged outdefault sourceN/AN/Ashow source
Logged outN/AN/APublished ≥1 comment with the Reply toolshow the last Reply text input mode used to publish a comment

Open questions

  • 1. Question: is a separate ticket needed to ensure the code that determines what Reply Tool text input mode people see by default takes into account peoples' potential prior use of the New Discussion Tool? Context: The logic above varies slightly from that implemented in T250523. It varies in so far as the logic above takes into account peoples' potential prior use of the Reply Tool when determining whether people see the New Discussion Tool's source or visual mode for the first time.
    • A separate ticket is not needed to ensure the New Discussion Tool is "aware" of peoples' use, or lack thereof, of the Reply Tool and vice versa.
    • Reasons:
      • The New Discussion Tool and Reply Tool use the same preference. This means, the mode (read: source / visual) people use in one tool will affect the mode they see when opening the other tool.
      • See: T270685#6733080.
  • 2. What text input mode should people see when using the New Discussion Tool for with preloaded context? More context in T269310#6699739.
    • We will address this question in T270797. See question #1 within the task's ===Open questions section.

Testing instructions

  • If QA has a vagrant virtual machine, all configurations described in the "Text input mode configuration" and "Partner wiki article editor default configurations" section can be tested.
  • If QA does NOT have a vagrant virtual machine, ONLY the user-level configurations (read: preferences) described in the "Text input mode configuration" section can be tested; the "Partner wiki article editor default configurations" can be tested as well.

Done

  • Behavior described in "Text input mode configuration" has been implemented

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedppelberg
ResolvedRyasmeen
Resolvedmatmarex
ResolvedEsanders
Resolvedmatmarex
ResolvedWhatamidoing-WMF
ResolvedWhatamidoing-WMF
Resolvedppelberg
Resolvedmatmarex
ResolvedWhatamidoing-WMF
ResolvedWhatamidoing-WMF
Resolvedmatmarex
ResolvedWhatamidoing-WMF
Resolvedmatmarex
ResolvedWhatamidoing-WMF
OpenNone
OpenNone
OpenNone
OpenMNeisler
Resolvedppelberg
DuplicateNone

Event Timeline

Notes from the conversation @Esanders and I had on 22-Dec-2020

  • The New Discussion Tool and Reply Tool use the same preference
    • This means, by default, the New Discussion Tool will behave as the Reply Tool currently does. This behavior was described and implemented in T250523.
    • This also means, the mode (read: source / visual) people use in one tool will affect the mode they see when opening the other tool.

I've updated the task description's ===Open questions section to reflect the above.

META
I am closing this task as a duplicate of T250523 considering:

  • T250523 implements the behavior this task is asking for.
  • All ===Open questions in the task description have been addressed.
    • Note: we will address the question around what text input mode people should see by default when opening the New Discussion Tool that contains a preload in T270797.