Page MenuHomePhabricator

Drop hacky support for doctrine/dbal class renaming
Closed, ResolvedPublic

Description

Following up from T270732: Upgrade doctrine/dbal from 2.10.4 to 3.0.x for PHP 8.0 support, blocked on T261872: Drop PHP 7.2 & 7.3 support from MediaWiki master branch, once Wikimedia production is on 7.4...

When we drop PHP 7.2 support in master (like in MW 1.35), after WMF production is on 7.3... We can clean up the hacks in includes/libs/rdbms/database/DoctrineSchemaBuilderFactory.php, while removing support for doctrine/dbal < 3.0.0

Related Objects

StatusSubtypeAssignedTask
ResolvedLadsgroup
ResolvedJdforrester-WMF
ResolvedJoe
ResolvedDzahn
Resolvedhashar
ResolvedJdforrester-WMF
ResolvedLadsgroup
ResolvedMoritzMuehlenhoff
Resolvedjijiki
ResolvedMoritzMuehlenhoff
ResolvedTrizek-WMF
ResolvedDzahn
Resolved Gilles
ResolvedDzahn
ResolvedRequestPapaul
Resolvedjijiki
DeclinedNone
ResolvedDzahn
ResolvedDzahn
ResolvedPapaul
Resolved Cmjohnson
ResolvedRequest Cmjohnson
ResolvedRequestPapaul
ResolvedAndrew
ResolvedArielGlenn
ResolvedDzahn
ResolvedLegoktm
ResolvedPapaul
ResolvedDzahn
Declined Gilles
ResolvedVolans
ResolvedDzahn
ResolvedLegoktm
ResolvedPleaseStand
ResolvedJoe
Resolved tstarling
ResolvedArielGlenn
ResolvedJoe
Resolved tstarling
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedLegoktm
ResolvedJdforrester-WMF
ResolvedDaimona
ResolvedDaimona
ResolvedJdforrester-WMF
ResolvedJoe
ResolvedJMeybohm
ResolvedJoe
ResolvedJoe
ResolvedJoe
ResolvedJoe
ResolvedKrinkle
ResolvedJoe
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedMainframe98
ResolvedJoe
ResolvedZabe

Event Timeline

Change 651628 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Drop support for doctrine/dbal < 3.0.0

https://gerrit.wikimedia.org/r/651628

Change 678108 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_36] Tweaks post branching...

https://gerrit.wikimedia.org/r/678108

Change 678108 merged by jenkins-bot:

[mediawiki/core@REL1_36] Bring REL1_36 requirements into line with REL1_35.

https://gerrit.wikimedia.org/r/678108

Ladsgroup subscribed.

This is blocked on dropping support for php 7.2

Reedy triaged this task as Low priority.Apr 5 2022, 1:52 PM

Change 836843 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Drop support for doctrine/dbal < 3.0.0

https://gerrit.wikimedia.org/r/836843

Change 651628 abandoned by Jforrester:

[mediawiki/core@master] Drop support for doctrine/dbal < 3.0.0

Reason:

Re-done in I17d74705cdd5a2e1af0bda66bfa466067b8387a8

https://gerrit.wikimedia.org/r/651628

Change 836843 merged by jenkins-bot:

[mediawiki/core@master] Drop support for doctrine/dbal < 3.0.0

https://gerrit.wikimedia.org/r/836843

Ladsgroup claimed this task.