Page MenuHomePhabricator
Create Task
Maniphest T270769

Wikimedia\Rdbms\DBQueryError: Error 1176: Key 'times' doesn't exist in table 'logging'
Closed, ResolvedPublic
Actions

Description

This seems to be an omission in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/648817 aka rMW443c94de3f48: Rename four logging indexes to have log_ prefix

There are at least two places where times index is referred: https://codesearch.wmcloud.org/search/?q=IGNORE%20INDEX.*logging&i=nope&files=&repos=

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Better handling for Logging index that's being renamedmediawiki/coremaster+4 -1
Reflect name change of logging indexes in codemediawiki/coremaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nikerabbit created this task.Dec 23 2020, 2:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 23 2020, 2:49 PM
Nikerabbit triaged this task as Unbreak Now! priority.Dec 23 2020, 2:49 PM
Nikerabbit lowered the priority of this task from Unbreak Now! to High.Dec 23 2020, 3:10 PM
Nikerabbit moved this task from Backlog to Mitigated on the affects-translatewiki.net board.

Not sure why I cannot reproduce this on beta cluster (schema change not done there?).

gerritbot added a comment.Dec 23 2020, 6:49 PM

Change 651817 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Reflect name change of logging indexes in code

https://gerrit.wikimedia.org/r/651817

gerritbot added a project: Patch-For-Review.Dec 23 2020, 6:49 PM
Ladsgroup added a comment.Dec 24 2020, 6:22 AM

One note is that PG had a completely different index name, I wonder how it worked in PG.

gerritbot added a comment.Dec 24 2020, 6:32 AM

Change 651817 merged by jenkins-bot:
[mediawiki/core@master] Reflect name change of logging indexes in code

https://gerrit.wikimedia.org/r/651817

Ladsgroup closed this task as Resolved.Dec 24 2020, 6:54 AM
Ladsgroup assigned this task to Ammarpad.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 24 2020, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 24 2020, 7:10 AM
Nikerabbit mentioned this in T270902: Key 'page_time' doesn't exist in table 'logging'.Dec 29 2020, 8:54 AM
DannyS712 added a parent task: T267418: 1.36.0-wmf.25 deployment blockers.Dec 29 2020, 10:04 AM
gerritbot added a comment.Dec 29 2020, 12:56 PM

Change 652401 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Better handling for Logging index that's being renamed

https://gerrit.wikimedia.org/r/652401

gerritbot added a project: Patch-For-Review.Dec 29 2020, 12:56 PM
gerritbot added a comment.Dec 29 2020, 2:05 PM

Change 652401 merged by jenkins-bot:
[mediawiki/core@master] Better handling for Logging index that's being renamed

https://gerrit.wikimedia.org/r/652401

Maintenance_bot removed a project: Patch-For-Review.Dec 29 2020, 2:10 PM
Mainframe98 awarded a token.Dec 29 2020, 2:21 PM
Umherirrender subscribed.Dec 29 2020, 8:19 PM

In the past there was some index alias support - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/411892/11/includes/db/MWLBFactory.php

But it seems unused and may not altered by config/DBAs

I am not sure if the performance or way of Database::indexExists is okay to have it per request, because it is normally not used outside of the updater and maintenance scripts

Ladsgroup added a comment.Jan 1 2021, 1:13 PM
In T270769#6714024, @Umherirrender wrote:

I am not sure if the performance or way of Database::indexExists is okay to have it per request, because it is normally not used outside of the updater and maintenance scripts

I have considered it but at the end decided to move forward because:

  • This is temporary and will be removed later
  • Checking existence of index is pretty cheap.
  • Both cases are rare cases, Special:Checkuser is being invoked quite irregularly (maybe once every minute or so) and query log is small, not to mention these tables are pretty small these days.
Jdforrester-WMF subscribed.Jan 5 2021, 10:05 PM
In T270769#6715923, @Ladsgroup wrote:
In T270769#6714024, @Umherirrender wrote:

I am not sure if the performance or way of Database::indexExists is okay to have it per request, because it is normally not used outside of the updater and maintenance scripts

I have considered it but at the end decided to move forward because:

  • This is temporary and will be removed later
  • Checking existence of index is pretty cheap.
  • Both cases are rare cases, Special:Checkuser is being invoked quite irregularly (maybe once every minute or so) and query log is small, not to mention these tables are pretty small these days.

Does this still hold true with ae59076f2c420b444755e3ce7702a80a26df8da2 // T271259? That's a fair bit more widespread…

Ladsgroup added a comment.Jan 5 2021, 10:10 PM

LogPager is slightly more used but not that much. If it's really going to cause an issue or not is not 100% known to me, I can measure it with deploying the change to mwdebug1001 and profile it but that's it.

Ladsgroup added a comment.Jan 5 2021, 11:11 PM

XHGui didn't show any issues with calling the indexExists() function: https://performance.wikimedia.org/xhgui/run/symbol?id=5ff4f15260fe51267d354f09&symbol=LogPager%3A%3AgetQueryInfo

Ammarpad mentioned this in T271506: Use index remapping instead of full query for in-progress index renaming.Jan 8 2021, 7:18 AM
Ammarpad added a comment.Jan 8 2021, 7:22 AM

I have created T271506. IDatabase::indexExists does indeed involve full query and I didn't know that we have better alternative that needs no query at all.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits