Page MenuHomePhabricator
Create Task
Maniphest T270795

cumin's test dependencies trigger excessive pip backtracking
Closed, ResolvedPublic
Actions

Description

In attempting to migrate cumin's CI tests to run on our buster image, which includes Python 3.8, cumin ends up triggering the new pip resolver's excessive backtracking, hitting Jenkin's 20 minute timeout. It is possible that collectively cumin's dependencies are incompatible with each other or hit an edge case that could be sped up with stricter requirements.

https://pip.pypa.io/en/latest/user_guide/#changes-to-the-pip-dependency-resolver-in-20-3-2020

Once this is fixed we can start testing with Python 3.8 in CI.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
tests: fix dependencies for testsVolansoperations/software/cuminmaster+6 -3
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Dec 23 2020, 11:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 23 2020, 11:00 PM
Jdforrester-WMF subscribed.Dec 24 2020, 12:07 AM
gerritbot added a comment.Dec 24 2020, 12:22 PM

Change 651913 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] tests: fix dependencies for tests

https://gerrit.wikimedia.org/r/651913

gerritbot added a project: Patch-For-Review.Dec 24 2020, 12:22 PM
Volans claimed this task.Dec 24 2020, 12:23 PM
Volans removed Volans as the assignee of this task.Dec 24 2020, 12:34 PM

@Legoktm thanks for filing the bug. It should be fixed now with the above patch merged. Could you confirm and resolve this task if it's all good?

gerritbot added a comment.Dec 24 2020, 12:37 PM

Change 651913 merged by jenkins-bot:
[operations/software/cumin@master] tests: fix dependencies for tests

https://gerrit.wikimedia.org/r/651913

Maintenance_bot removed a project: Patch-For-Review.Dec 24 2020, 1:10 PM
Volans mentioned this in rCUMIN670dc5aaef32: tests: fix dependencies for tests.Dec 24 2020, 2:50 PM
Jdforrester-WMF closed this task as Resolved.Dec 31 2020, 12:15 AM
Jdforrester-WMF assigned this task to Volans.

Yup, that fixed it, thank you! I've moved the CI jobs over to buster.

https://integration.wikimedia.org/ci/job/cumin-tox-docker/100/console
https://integration.wikimedia.org/ci/job/cumin-tox-publish/84/console

Jdforrester-WMF mentioned this in T270969: homer's tests on master don't pass on old stretch CI or on new buster CI image.Dec 31 2020, 2:15 AM
jbond reopened this task as Open.Jan 12 2021, 5:10 PM
jbond subscribed.

Still seeing issues with this, i think before Christmas you mentioned you may need to do a release so projects which depend on cumin can run test.

Volans added a comment.Jan 12 2021, 6:01 PM
In T270795#6740423, @jbond wrote:

Still seeing issues with this, i think before Christmas you mentioned you may need to do a release so projects which depend on cumin can run test.

Yes, I need to make a cumin release to solve this for you, sorry about that.

Volans closed this task as Resolved.May 12 2021, 10:23 PM

Cumin 4.1.0 has been released to PyPI, resolving. Feel free to re-open in case there is still any issue.

Aklapper edited projects, added: Cumin; removed: SRE-tools.May 10 2023, 11:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits