Page MenuHomePhabricator

[[Wikimedia:Toolhub-js-auditlog-summary/he]] translation issue
Closed, ResolvedPublic

Description

The message Toolhub-js-auditlog-summary has hard-to-understand text: {action}d a {target}.

This needs proper documentation.

Perhaps it doesn't have to be translated at all? If so, it can be defined as "ignored" on translatewiki.


URL: https://translatewiki.net/wiki/Wikimedia:Toolhub-js-auditlog-summary/he

Event Timeline

Amire80 created this task.Dec 24 2020, 1:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 24 2020, 1:17 PM

The vue-i18n library currently being used in the Toolhub project allows {keyword} syntax for placeholders that will be replaced with values. This is similar to the Banana $1...$n placeholder syntax with theoretically meaningful labels being used rather than simply numbers for the variables.

{action}d is gross. We need to do something else for this for sure. The author of the en message apparently wanted to change the tense of the action value provided by the backend API. The 3 current action values ("create", "update", delete") are in present tense, but it really would make more sense for them to be in past tense as this message string attempts to do for English.

Change 652267 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[wikimedia/toolhub@main] i18n: Document parameters & plurals; tense change

https://gerrit.wikimedia.org/r/652267

bd808 claimed this task.Tue, Dec 29, 2:25 AM
bd808 triaged this task as Medium priority.
bd808 moved this task from Backlog to In Progress on the Toolhub board.
Restricted Application added a project: User-bd808. · View Herald TranscriptTue, Dec 29, 2:25 AM

Change 652267 merged by jenkins-bot:
[wikimedia/toolhub@main] i18n: Document parameters & plurals; tense change

https://gerrit.wikimedia.org/r/652267

bd808 closed this task as Resolved.Wed, Dec 30, 11:40 PM

Change 656003 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[wikimedia/toolhub@main] auditlog: Add missing migration for action tense change

https://gerrit.wikimedia.org/r/656003

Change 656003 merged by jenkins-bot:
[wikimedia/toolhub@main] auditlog: Add missing migration for action tense change

https://gerrit.wikimedia.org/r/656003