Page MenuHomePhabricator

CentralAuthUtils should use dependency injection
Closed, ResolvedPublic


CentralAuthUtils is currently full of static methods calling MediaWikiServices::getInstance()... let's move that to a DI-able class and inject the necessary services?

also naming suggestings for the new class are welcome... CentralAuthUtilities? CentralAuthServices?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 651945 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/CentralAuth@master] [WIP] Add DI-friendly CentralAuthServices instead of CentralAuthUtils

Change 651945 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Add injectable CentralAuthUtilityService to replace CentralAuthUtils