Page MenuHomePhabricator
Create Task
Maniphest T270879

EchoApi.markAllRead( 'local', 'all' ) has no effect
Closed, ResolvedPublicBUG REPORT
Actions

Description

When I test in my browser's console with any Wikipedia, (new mw.echo.api.EchoApi()).markAllRead( 'local', 'all' ); has no effect,
but only markAllRead( 'local', [ 'message', 'alert' ] ); works.
It is not the spec, I guess.

Details

SubjectRepoBranchLines +/-
Handle the missing 'all' type as specified in the docmediawiki/extensions/Echomaster+11 -5
Customize query in gerrit

Event Timeline

Lens0021 created this task.Dec 28 2020, 4:44 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 28 2020, 4:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Dec 28 2020, 11:24 PM

Change 652212 had a related patch set uploaded (by Lens0021; owner: Lens0021):
[mediawiki/extensions/Echo@master] Allow 'all' for ApiEchoMarkRead's sections param

https://gerrit.wikimedia.org/r/652212

gerritbot added a project: Patch-For-Review.Dec 28 2020, 11:24 PM
Lens0021 added a project: MediaWiki-Action-API.Dec 30 2020, 12:07 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
Lens0021 claimed this task.May 31 2021, 5:45 PM
Lens0021 changed the subtype of this task from "Task" to "Bug Report".Mar 24 2022, 6:34 AM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team-Filtering, Growth-Team.Apr 25 2022, 12:39 PM
kostajh moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Apr 25 2022, 12:55 PM

Change 652212 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Handle the missing 'all' type as specified in the doc

https://gerrit.wikimedia.org/r/652212

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.9; 2022-04-25).Apr 25 2022, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 25 2022, 1:30 PM
Umherirrender closed this task as Resolved.Apr 25 2022, 5:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits