Page MenuHomePhabricator

LDAPAuthentication2::authenticate() should allow subclasses more places to override authentication
Open, Needs TriagePublic

Description

For example, I'm working on a WikiToLDAP extension. They want their users to be able to merge their wiki account with their LDAP account after authenticating as both users.

If I can override bits of authenticate(), it will make my job easier.

Event Timeline

Change 652190 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/extensions/LDAPAuthentication2@master] Refactor individual local/ldap checking bits into protected methods

https://gerrit.wikimedia.org/r/652190

Change 654850 had a related patch set uploaded (by Robert Vogel; owner: MarkAHershberger):
[mediawiki/extensions/LDAPAuthentication2@REL1_35] Refactor individual local/ldap checking bits into protected methods

https://gerrit.wikimedia.org/r/654850

Change 654851 had a related patch set uploaded (by Robert Vogel; owner: MarkAHershberger):
[mediawiki/extensions/LDAPAuthentication2@REL1_31] Refactor individual local/ldap checking bits into protected methods

https://gerrit.wikimedia.org/r/654851

Change 652190 merged by Robert Vogel:
[mediawiki/extensions/LDAPAuthentication2@master] Refactor individual local/ldap checking bits into protected methods

https://gerrit.wikimedia.org/r/652190

Change 654850 merged by Robert Vogel:
[mediawiki/extensions/LDAPAuthentication2@REL1_35] Refactor individual local/ldap checking bits into protected methods

https://gerrit.wikimedia.org/r/654850

Change 654851 merged by Robert Vogel:
[mediawiki/extensions/LDAPAuthentication2@REL1_31] Refactor individual local/ldap checking bits into protected methods

https://gerrit.wikimedia.org/r/654851