The public methods OO.ui.infuse and OO.ui.Element.static.infuse call the private method OO.ui.Element.static.unsafeInfuse. These methods accept an HTMLElement or a jQuery collection. Their documentation implies that the jQuery collection should only contain one node, but this is not actually enforced.
If a jQuery collection containing more than one node is passed, the data from the first node will be used to silently overwrite any subsequent nodes. Instead, an error should be thrown.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update OOUI to v0.41.1 | mediawiki/core | master | +335 -133 | |
| Throw error if OO.ui.infuse called on more than one node | oojs/ui | master | +19 -6 |
Most callers do only pass one node, so this should be safe to do: https://codesearch.wmcloud.org/deployed/?q=.infuse%5C(&i=nope&files=&repos=
A counter-example (and the reason this issue was noticed) is cloner.js: T270961
Change 652609 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[oojs/ui@master] Throw error if OO.ui.infuse called on more than one node
Change 652609 merged by jenkins-bot:
[oojs/ui@master] Throw error if OO.ui.infuse called on more than one node
Change 658692 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.41.1