Page MenuHomePhabricator
Create Task
Maniphest T270969

homer's tests on master don't pass on old stretch CI or on new buster CI image
Closed, ResolvedPublic
Actions

Description

In attempting to migrate homer's CI tests to run on our buster image, which includes Python 3.8, I've found that it's taking an awfully long time and eventually times out on the test installdeps steps; possibly the same problem as T270795: cumin's test dependencies trigger excessive pip backtracking? https://integration.wikimedia.org/ci/job/homer-tox-docker/179/console

Note however that the test also seem to not pass on the old stretch image we're moving from, erroring in the "py37-bandit" step: https://integration.wikimedia.org/ci/job/homer-tox-docker/178/console

Details

ProjectBranchLines +/-Subject
operations/software/homermaster+1 -2dependencies: remove upper limit for prospector
operations/software/homermaster+3 -3tox: Remove '--skip B322' from Bandit config.
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Dec 31 2020, 2:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 31 2020, 2:15 AM
Volans claimed this task.Jan 4 2021, 9:26 AM
gerritbot added a comment.Jan 4 2021, 9:39 AM

Change 654186 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/homer@master] tox: Remove '--skip B322' from Bandit config.

https://gerrit.wikimedia.org/r/654186

gerritbot added a project: Patch-For-Review.Jan 4 2021, 9:39 AM
Volans added a comment.Jan 4 2021, 9:41 AM

The failures on the old CI are fixed by the above patch, a newer version of bandit is failing instead of ignoring a no longer used error code to exclude.
I'm looking at the new pip resolver failure that makes pip fail with a stacktrace. It's not the same as the one for cumin unfortunately. I've also submitted the form upstream to let them aware of the failure.

gerritbot added a comment.Jan 4 2021, 9:44 AM

Change 654186 merged by jenkins-bot:
[operations/software/homer@master] tox: Remove '--skip B322' from Bandit config.

https://gerrit.wikimedia.org/r/654186

Maintenance_bot removed a project: Patch-For-Review.Jan 4 2021, 10:10 AM
Volans mentioned this in rOSHOf7f1420816fb: tox: Remove '--skip B322' from Bandit config..Jan 4 2021, 12:54 PM
Jdforrester-WMF added a comment.Jan 4 2021, 3:42 PM

Thank you!

gerritbot added a comment.Jan 4 2021, 10:27 PM

Change 654320 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/homer@master] dependencies: remove upper limit for prospector

https://gerrit.wikimedia.org/r/654320

gerritbot added a project: Patch-For-Review.Jan 4 2021, 10:27 PM
Volans added a comment.Jan 4 2021, 10:32 PM

@Jdforrester-WMF The merged patch above should have fixed this backtracking too. Feel free to resolve this task if it works with the new pip in CI too. Thanks for letting us know.

gerritbot added a comment.Jan 4 2021, 10:34 PM

Change 654320 merged by jenkins-bot:
[operations/software/homer@master] dependencies: remove upper limit for prospector

https://gerrit.wikimedia.org/r/654320

Volans mentioned this in rOSHOf65e03676da1: dependencies: remove upper limit for prospector.Jan 4 2021, 10:35 PM
Jdforrester-WMF closed this task as Resolved.Jan 4 2021, 10:42 PM

Yup, works great: https://integration.wikimedia.org/ci/job/homer-tox-docker/187/console

Thanks!

Maintenance_bot removed a project: Patch-For-Review.Jan 4 2021, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL