Page MenuHomePhabricator

Danglers in the username dropdown are cut off
Open, Needs TriagePublicBUG REPORT

Description

For example:

There are a few methods of solving this:

  • Replace the #personal h2 span height with line-height: normal; (what I currently pushed)
  • The overflow: hidden; on #user-tools h2 span (line 67) could have been removed
    • In addition to the above, the height: 18px; directly below could probably be removed as the dropdown arrow alignment could be better that way, but that might be a browser specific thing.
  • The #personal h2 span height could probably just be increased to 1.5em.

Here's what it looks fixed:


And here's what it looks like without the overflow or 18px height on the #user-tools #personal h2:after:

None of these seem to have any unintended side-effect, but there might be a reason (or a browser-specific thing) for some of those existing that I'm not aware of.

Event Timeline

Change 653548 had a related patch set uploaded (by Perryprog; owner: Perryprog):
[mediawiki/skins/Timeless@master] Replace manually set height for #personal username with default line height

https://gerrit.wikimedia.org/r/653548

So part of the issue here seems to be that the alignment is quite off in general - could you clarify what OS and browser you're using? I'm not seeing any clipping, and on mine, this just makes the alignment issues worse. Which likely means there's a font issue or something?

Mind you, clipping it off when the alignment gets off isn't exactly a good solution, so we might as well merge the associated patch, too, but I suspect there's more that needs resolving here...

I'm running macOS Big Sur, here's some more screenshots with rules.
Safari 14.0.2:


Safari Technology Preview 14.1:

Firefox 84:

I bet you're right on it being a font issue—I (surprisingly, for me) don't have Linux Libertine installed, so it's falling back to Times New Roman. I'll be able to confirm it tomorrow morning as it's late for me already.

Change 653548 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Replace manually set height for #personal username with default line height

https://gerrit.wikimedia.org/r/653548