Page MenuHomePhabricator
Create Task
Maniphest T271068

Fix the Athena skin for 1.35 compatibility
Closed, DeclinedPublic
Actions

Description

I've marked the Athena skin as unmaintained as it hasn't seen any activity in over a year and causes fatals when loaded in the current state with the current 1.35 release due to its use of include

( Warning: include(Athena.phtml): failed to open stream: No such file or directory in /Users/jrobson/git/core/skins/Athena/includes/AthenaTemplate.php on line 25)

If the skin is maintained, I'm happy to help review a patch and update the mediawiki page, but in current state we should not mislead MediaWiki users by advertising something broken as beta.

Details

SubjectRepoBranchLines +/-
Restore styles to Athenamediawiki/skins/Athenamaster+11 -18
Fix paths of the filesmediawiki/skins/Athenamaster+10 -8
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jan 3 2021, 6:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 3 2021, 6:46 PM
Kizule claimed this task.EditedJan 4 2021, 10:57 AM
Kizule subscribed.

I found what is problem. AthenaTemplate.php is in includes directory. It requires Athena.phtml and expects that Athena.phtml is in includes/, but It is in root.

I'm going to make a patch.

Restricted Application added a project: User-Kizule. · View Herald TranscriptJan 4 2021, 10:57 AM
gerritbot added a comment.Jan 4 2021, 11:03 AM

Change 654194 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/skins/Athena@master] Fix paths of the files

https://gerrit.wikimedia.org/r/654194

gerritbot added a project: Patch-For-Review.Jan 4 2021, 11:03 AM
Kizule moved this task from Inbox to To deploy on the User-Kizule board.Jan 4 2021, 11:03 AM
gerritbot added a comment.Jan 4 2021, 1:55 PM

Change 654194 merged by jenkins-bot:
[mediawiki/skins/Athena@master] Fix paths of the files

https://gerrit.wikimedia.org/r/654194

Maintenance_bot removed a project: Patch-For-Review.Jan 4 2021, 2:10 PM
Jdlrobson added a comment.EditedJan 4 2021, 4:45 PM

Thanks for the patch! That definitely is a big bit of progress.

I'm still seeing a couple of errors in this skin which I think need to be fixed if we are going to call this maintained:

  • Deprecated: Use of BaseTemplate::getToolbox was deprecated in MediaWiki 1.35. [Called from include in /Users/jrobson/git/core/skins/Athena/resources/Athena.phtml at line 61] in /Users/jrobson/git/core/includes/debug/MWDebug.php on line 329
  • No styles are loaded (fixed in patch above)
  • Site notice overlaps the sidebar per screenshot below!

Screen Shot 2021-01-04 at 8.44.37 AM.png (972×2 px, 244 KB)

@sophivirus @Kizule would you be able to take a look?

gerritbot added a comment.Jan 4 2021, 4:52 PM

Change 654274 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Athena@master] Restore styles to Athena

https://gerrit.wikimedia.org/r/654274

gerritbot added a project: Patch-For-Review.Jan 4 2021, 4:52 PM
Jdlrobson renamed this task from Fix or archive Athena skin to Fix the Athena skin for 1.35 compatibility.Jan 4 2021, 4:56 PM
gerritbot added a comment.Jan 4 2021, 6:01 PM

Change 654274 merged by jenkins-bot:
[mediawiki/skins/Athena@master] Restore styles to Athena

https://gerrit.wikimedia.org/r/654274

Kizule reassigned this task from Kizule to Sophivorus.Jan 4 2021, 7:30 PM
Kizule moved this task from To deploy to Watching on the User-Kizule board.

I'm reassigning this task to @Sophivorus, as he told in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Athena/+/654194/ that he will release new full update in the future.

Sophivorus closed this task as Declined.Jan 18 2022, 8:24 PM

Athena skin is being archived, see T299322.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL