The CacheTime class currently accesses $wgParserCacheExpireTime directly to check for expiry. However, CacheTime, which acts as a base class for entries in ParserCache, should be a value object - it not use global state and should not know about configuration variables. Checking the expiry time against configuration and wall clock time should be left to the cache object, it should not be done by the entry itself.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| ParserCache: don't rely on $wgParserCacheExpireTime | mediawiki/core | master | +58 -43 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T270710 Allow values other than ParserOutput to be stored in a ParserCache instance | |||
| Resolved | • Pchelolo | T250500 ParserCache / RESTBase / Parsoid integration | |||
| Open | None | T271112 Do not access global $wgParserCacheExpireTime directly |
Event Timeline
Comment Actions
Change 651205 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] ParserCache: don't rely on $wgParserCacheExpireTime
Comment Actions
Adding Platform Engineering as Platform Team Workboards (Green) was archived and as open tasks should have an active project tag
Comment Actions
@daniel: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on Feburary 22nd, 2023.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!