Page MenuHomePhabricator

Do not access global $wgParserCacheExpireTime directly
Open, Needs TriagePublic

Description

The CacheTime class currently accesses $wgParserCacheExpireTime directly to check for expiry. However, CacheTime, which acts as a base class for entries in ParserCache, should be a value object - it not use global state and should not know about configuration variables. Checking the expiry time against configuration and wall clock time should be left to the cache object, it should not be done by the entry itself.

Event Timeline

Change 651205 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] ParserCache: don't rely on $wgParserCacheExpireTime

https://gerrit.wikimedia.org/r/651205