iOS Wikipedia app adds unexpected … tags in wikitext whenever posting a talk page message
Closed, ResolvedPublic
Actions

Description

iOS Wikipedia app adds unexpected … tags in wikitext whenever posting a talk page message. The issue appears in every recent edit, on every Wikipedia, as far as I can tell; for example, check the en.wp recent changes.

Examples:

The and tags should not appear.

(We identified this issue while reviewing edits made using DiscussionTools, which interacts with these tags in funny ways. Diffs for reference: 1 2 3 4 .)

Event Timeline

matmarex created this task.Jan 4 2021, 8:08 PM

Restricted Application added a project: Wikipedia-iOS-App-Backlog. · View Herald TranscriptJan 4 2021, 8:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Esanders triaged this task as High priority.Jan 4 2021, 8:24 PM

This looks like the source: https://github.com/wikimedia/wikipedia-ios/commit/f64a83b00275d13439b2d9c5cf5dcaf169b8226f

PR: https://github.com/wikimedia/wikipedia-ios/pull/3818

Tsevener added a project: iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower.Jan 8 2021, 4:54 PM

Tsevener moved this task from Tasks from Product Backlog to Waiting for Build on the iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower board.

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Jan 11 2021, 7:32 PM

@Tsevener do you find that most users auto-update to the latest version of the app quite quickly? i.e. should we expect to see edits with the tags dry up soon after the deployment?

For our last release, within 4 days 82% of our sessions were on the newest version, within 7 days it was 91% so the uptake is rather quick. We're considering a hot fix release for another issue that would go out in the next week, and your patch is now merged into that. I can ping this ticket when our release plans are confirmed.

Note for QA: this fix is in the TestFlight build 6.7.4 (1791).

Esanders moved this task from Backlog to External on the Editing-team (Tracking) board.Jan 20 2021, 3:53 PM

Appears to be fixed on 6.7.3 (1791)

This was released to store just now, so by next week you should see a major drop off in the bad tags.

also pinging
@JTannerWMF and @Dbrant as Android is actively working on Talk tools. Just FYI guys there was some bad markup in the iOS auto-sig, so you should check that Android didn't do that as well.

Seems like this was successfully changed in talk posts from iOS, so I'm resolving.

iOS Wikipedia app adds unexpected <p>…</p> tags in wikitext whenever posting a talk page messageClosed, ResolvedPublicActions

Description

Event Timeline

iOS Wikipedia app adds unexpected <p>…</p> tags in wikitext whenever posting a talk page message
Closed, ResolvedPublic
Actions