Page MenuHomePhabricator

[FIXED] Autoedit parser function drops values of datepicker and datetimepicker input types
Closed, ResolvedPublic

Description

MW 1.34, PF=5.0.1 (731d226, Dec. 28th)

Prior to 5.0 #autoedit parser function could update templates without issue. Since PF 5.0 (and including 5.0.1) the autoedit parser function is dropping dates from the template when used.

Example:
{{#autoedit:form=MyForm|query string=MyTemplate[MyProp1]=ABC| ... }}

turns:

{{MyTemplate|MyDate1=2020-01-05|MyProp1=XYZ}}

into:

{{MyTemplate|MyProp1=ABC}}

Event Timeline

comment deleted as it was for a different task.

Yaron_Koren renamed this task from Autoedit parser function drops dates to Autoedit parser function drops values of datepicker and datetimepicker input types.Jan 18 2021, 5:01 PM

Change 657107 had a related patch set uploaded (by Yaron Koren; owner: Yaron Koren):
[mediawiki/extensions/PageForms@master] Restore datepicker, datetimepicker support in #autoedit

https://gerrit.wikimedia.org/r/657107

Change 657107 merged by jenkins-bot:
[mediawiki/extensions/PageForms@master] Restore datepicker, datetimepicker support in #autoedit

https://gerrit.wikimedia.org/r/657107

just fyi, I tested the latest version of PF as of Jan. 24th 12:50am and this issue is not yet resolved.

That's strange - I can no longer replicate this problem.

Hmm.. that is odd. I'll test it again tonight and report again. Maybe I did something wrong with the git checkout

I fetched the latest version last night and checked out master and the problem still persists. I'll provide screenshots of all the relevant observables.

Revansx renamed this task from Autoedit parser function drops values of datepicker and datetimepicker input types to [FIXED] Autoedit parser function drops values of datepicker and datetimepicker input types.Feb 11 2021, 1:06 AM
Revansx closed this task as Resolved.

Apparently my knowledge of git is not what it needs to be.

I don't know which commit actually fixed it, but I discovered that just doing:

git fetch https://github.com/wikimedia/mediawiki-extensions-PageForms.git
git checkout master

wasn't enough to get my version of PF truly up to date with the the latest version.

Turns out I had to:

git fetch --all
git reset --hard origin/master

in order to get the latest version in my project.

Thanks!

Thank 'You'! .. I'm happy to say that I'm now on PF 5.1 .. w00t!