Page MenuHomePhabricator

Create Special:SecurePollLog page
Closed, ResolvedPublic5 Estimated Story Points

Description

Special:SecurePollLog will display data logged in T271275: Log when admins are added to or removed from SecurePoll elections and T271276: Log when admins access voter data in SecurePoll.

This first task is for displaying the logs. Filters will be added in a follow-up task: T271279

What we'll need
SpecialSecurePollLog class
  • extends FormSepcialPage
  • requires the 'securepoll-create-poll' right (see SpecialPage::__construct documentation)
  • should be listed in the same place as Special:SecurePoll on Special:SpecialPages
  • should be loaded conditionally on a new config variable, something like $wgSecurePollUseLogging
SecurePollLogPager class
  • extends ReverseChronologicalPager
  • formats the result rows into something readable
  • displays a message when there are no results

Examples of how to do all of these things can be found in this patch for SpecialInvestigateLog (since removed, so don't search the code for it!). Note that we don't need a PagerFactory.

Event Timeline

Niharika triaged this task as Medium priority.Jan 20 2021, 6:26 PM
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.

Change 659992 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/SecurePoll@master] Add Special:SecurePollLog for oversighting admin actions

https://gerrit.wikimedia.org/r/659992

Change 659992 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Add Special:SecurePollLog for oversighting admin actions

https://gerrit.wikimedia.org/r/659992

dom_walden added a subscriber: dom_walden.

We now have Special:SecurePollLog, which displays information from the securepoll_log table.

On my local environment, in order for a user to see the special page they need to be either in the electcomm or the sysop group. I don't know if this is configurable.

It requires a new config to be set: $wgSecurePollUseLogging = true;, which I don't believe it is on beta votewiki. I might need to raise a separate task for that.

specialsecurepolllog.png (230×904 px, 57 KB)

Test Environment vagrant SecurePoll 2.0.0 (ba52f2a).

Thanks @dom_walden

On my local environment, in order for a user to see the special page they need to be either in the electcomm or the sysop group. I don't know if this is configurable.

It's restricted to users with the 'securepoll-create-poll' right, so the way to configure it would be to give different groups that right. This was a bit of a guess - @jrbs and @drochford does this restriction sound appropriate?

It requires a new config to be set: $wgSecurePollUseLogging = true;, which I don't believe it is on beta votewiki. I might need to raise a separate task for that.

Filed as T273990