Create Special:SecurePollLog page
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	Jan 5 2021, 10:10 PM

Description

Special:SecurePollLog will display data logged in T271275: Log when admins are added to or removed from SecurePoll elections and T271276: Log when admins access voter data in SecurePoll.

This first task is for displaying the logs. Filters will be added in a follow-up task: T271279

What we'll need

SpecialSecurePollLog class

extends FormSepcialPage
requires the 'securepoll-create-poll' right (see SpecialPage::__construct documentation)
should be listed in the same place as Special:SecurePoll on Special:SpecialPages
should be loaded conditionally on a new config variable, something like $wgSecurePollUseLogging

SecurePollLogPager class

extends ReverseChronologicalPager
formats the result rows into something readable
displays a message when there are no results

Examples of how to do all of these things can be found in this patch for SpecialInvestigateLog (since removed, so don't search the code for it!). Note that we don't need a PagerFactory.

Details

	Subject	Repo	Branch	Lines +/-
	Add Special:SecurePollLog for oversighting admin actions	mediawiki/extensions/SecurePoll	master	+250 -3

Customize query in gerrit

Related Objects

Mentioned In: T271279: Add filters to Special:SecurePollLog page
Mentioned Here: T273990: Enable SecurePoll logging on votewiki, testwiki and beta
rESPOba52f2aa25b9: Localisation updates from https://translatewiki.net.
T271279: Add filters to Special:SecurePollLog page
T271275: Log when admins are added to or removed from SecurePoll elections
T271276: Log when admins access voter data in SecurePoll

Event Timeline

Tchanders created this task.Jan 5 2021, 10:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2021, 10:10 PM

Tchanders mentioned this in T271279: Add filters to Special:SecurePollLog page.Jan 5 2021, 10:11 PM

Tchanders updated the task description. (Show Details)

• Niharika triaged this task as Medium priority.Jan 20 2021, 6:26 PM

• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.

ARamirez_WMF set the point value for this task to 5.Jan 20 2021, 6:28 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jan 20 2021, 6:52 PM

ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

Tchanders updated the task description. (Show Details)Jan 22 2021, 11:51 PM

Tchanders claimed this task.Jan 27 2021, 4:01 PM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 659992 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/SecurePoll@master] Add Special:SecurePollLog for oversighting admin actions

https://gerrit.wikimedia.org/r/659992

gerritbot added a project: Patch-For-Review.Jan 29 2021, 8:59 PM

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jan 29 2021, 9:32 PM

Change 659992 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Add Special:SecurePollLog for oversighting admin actions

https://gerrit.wikimedia.org/r/659992

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).Feb 3 2021, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 3 2021, 12:11 AM

• wikitrent moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Feb 3 2021, 4:12 PM

We now have Special:SecurePollLog, which displays information from the securepoll_log table.

On my local environment, in order for a user to see the special page they need to be either in the electcomm or the sysop group. I don't know if this is configurable.

It requires a new config to be set: $wgSecurePollUseLogging = true;, which I don't believe it is on beta votewiki. I might need to raise a separate task for that.

specialsecurepolllog.png (230×904 px, 57 KB)

Test Environment vagrant SecurePoll 2.0.0 (ba52f2a).

Thanks @dom_walden

On my local environment, in order for a user to see the special page they need to be either in the electcomm or the sysop group. I don't know if this is configurable.

It's restricted to users with the 'securepoll-create-poll' right, so the way to configure it would be to give different groups that right. This was a bit of a guess - @jrbs and @drochford does this restriction sound appropriate?

It requires a new config to be set: $wgSecurePollUseLogging = true;, which I don't believe it is on beta votewiki. I might need to raise a separate task for that.

Filed as T273990

• Niharika closed this task as Resolved.Feb 8 2021, 12:42 PM

Create Special:SecurePollLog pageClosed, ResolvedPublic5 Estimated Story PointsActions