1.36.0-wmf.28 deployment blockers
Closed, DeclinedPublicRelease
Actions

Details

Backup Train Conductor: brennen
Release Version: 1.36.0-wmf.28
Release Date: Jan 25 2021, 12:00 AM

2021 week 04 1.36-wmf.28 Changes wmf/1.36.0-wmf.28

This MediaWiki Train Deployment is scheduled for the week of Monday, January 25th:

Monday January 25th	Tuesday, January 26th	Wednesday, January 27th	Thursday, January 28th	Friday
Backports only.	Branch `wmf.28` and deploy to Group 0 Wikis.	Deploy `wmf.28` to Group 1 Wikis.	Deploy `wmf.28` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.28 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.36.0-wmf.27

Next: 1.36.0-wmf.29

	Project	Branch	Lines +/-	Subject
	mediawiki/core	wmf/1.36.0-wmf.28	+971 -3	Branch commit for wmf/1.36.0-wmf.28

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined	Release	dancy	T271342 1.36.0-wmf.28 deployment blockers
		Resolved		aaron	T273006 MediumSpecificBagOStuff.php Undefined offset errors

Event Timeline

thcipriani created this task.Jan 6 2021, 4:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2021, 4:54 PM

thcipriani assigned this task to dancy.Jan 13 2021, 12:51 AM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: brennen.

thcipriani added a project: Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)) board.

Ladsgroup added a subtask: T260349: Wikibase does not purge cached Special:EntityData URLs when revisions or entities are deleted.Jan 20 2021, 7:08 PM

taavi added a subscriber: taavi.Jan 25 2021, 7:09 AM

Silvan_WMDE added a subscriber: Silvan_WMDE.Jan 25 2021, 10:25 AM

WMDE-leszek closed subtask T260349: Wikibase does not purge cached Special:EntityData URLs when revisions or entities are deleted as Resolved.Jan 25 2021, 6:32 PM

T260349 has been resolved by merging the necessary patches into Wikibase main. Therefore, I am removing it as a subtask.

Silvan_WMDE removed a subtask: T260349: Wikibase does not purge cached Special:EntityData URLs when revisions or entities are deleted.Jan 25 2021, 6:35 PM

Change 658479 had a related patch set uploaded (by DannyS712; owner: trainbranchbot):
[mediawiki/core@wmf/1.36.0-wmf.28] Branch commit for wmf/1.36.0-wmf.28

https://gerrit.wikimedia.org/r/658479

gerritbot added a project: Patch-For-Review.Jan 26 2021, 2:31 AM

Change 658479 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.28] Branch commit for wmf/1.36.0-wmf.28

https://gerrit.wikimedia.org/r/658479

brennen added a project: User-brennen.Jan 26 2021, 5:25 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.

brennen added a subscriber: brennen.

group0 rolled back due to T273006

Seeing several hits for T265720 error messages too.

dancy added subtasks: T273006: MediumSpecificBagOStuff.php Undefined offset errors, T265720: Failed assertion in TableFixups handler.Jan 26 2021, 9:44 PM

dancy removed a subtask: T265720: Failed assertion in TableFixups handler.Jan 26 2021, 10:07 PM

dancy removed a subtask: T273007: CacheTime.php Undefined index Version.Jan 26 2021, 11:52 PM

hashar added a subscriber: hashar.Jan 27 2021, 6:09 PM

brennen moved this task from Logs/Train to Doing on the User-brennen board.Jan 27 2021, 7:03 PM

Mentioned in SAL (#wikimedia-operations) [2021-01-27T20:29:59Z] <brennen> 1.36.0-wmf.28 (T271342): taking over train while dancy is afk; waiting on [[gerrit:658939]] to merge and will sync for verification on testwikis

aaron closed subtask T273006: MediumSpecificBagOStuff.php Undefined offset errors as Resolved.Jan 27 2021, 9:51 PM

Urbanecm added a subtask: T273120: ParserOptions.php PHP Notice: Undefined index: math.Jan 27 2021, 10:27 PM

Other new noise:

T273099: Undefined class constant 'BASE_CSS_CLASS'
T273101: Accessing WikiPage that cannot exist as a page: w:Help:Books/Book creator text.

matmarex mentioned this in T244114: "Publish" button remains greyed out: "TypeError: this.translationView.categoryUI is null".Jan 28 2021, 7:00 PM

taavi added a subtask: T273205: Argument 1 passed to CentralAuthUser::getInstance() must be an instance of User, boolean given.Jan 28 2021, 7:00 PM

Mentioned in SAL (#wikimedia-operations) [2021-01-28T21:15:29Z] <brennen> 1.36.0-wmf.28 train status (T271342): blockers resolved, going go group1 to be follow shortly by all wikis

brennen removed subtasks: T273205: Argument 1 passed to CentralAuthUser::getInstance() must be an instance of User, boolean given, T273120: ParserOptions.php PHP Notice: Undefined index: math.Jan 28 2021, 10:01 PM

brennen mentioned this in T273242: MemcachedPeclBagOStuff: Serialization of 'Closure' is not allowed.Jan 28 2021, 11:00 PM

brennen mentioned this in T273249: MimeAnalyzer::improveTypeFromExtension() must be of the type string, null given.Jan 28 2021, 11:29 PM

1.36.0-wmf.28 is running all wikis.

Notable errors:
T273101: WikiPage related errors. Looks like Daniel Kinzler has started working on this.
T273242: MemcachedPeclBagOStuff...Serialization of 'Closure' is now allowed. Filed not too long ago. No action yet.

dancy added subtasks: T273296: Some administrators can no longer add/remove users from the autochecked/editor user groups, T273317: some users with access are unable to configure pending changes.Jan 29 2021, 8:49 PM

RhinosF1 added a subscriber: RhinosF1.Jan 29 2021, 9:00 PM

T273296 was not able to be resolved in a timely manner so we decided to roll all wikis back to .27.

In T271342#6788523, @dancy wrote:

T273296 was not able to be resolved in a timely manner so we decided to roll all wikis back to .27.

Note to train conductor: That bug was successfully root-caused, with patch merged to master, and .28 backports proposed.

Go blocked due to the introduction of T254838: Move User::changeableGroups and User::changeableByGroup to UserGroupManager and User::changeable(By)Groups being hard deprecated in the process.

@Urbanecbm has done the rollback:

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/660533/
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/660649/

Will do the 1.36.0-wmf.28 updates today, exact schedule to be determinated.

Urbanecm removed a subtask: T273296: Some administrators can no longer add/remove users from the autochecked/editor user groups.Feb 1 2021, 1:32 PM

taavi removed a subtask: T273317: some users with access are unable to configure pending changes.Feb 1 2021, 1:40 PM

1.36.0-wmf.28 has reached group 1 an hour or so ago. Thanks @Urbanecm for the backports and the verification!

dancy added a subtask: T273249: MimeAnalyzer::improveTypeFromExtension() must be of the type string, null given.Feb 1 2021, 8:53 PM

@hasher et al, after discussion in IRC we release engineering has settled on rolling everything back to .27 and declining this .28 task. I will do the rollback at the next opportunity.

I moved remaining blockers over to the .29 task (T271343).

I will send an email notification too.

dancy closed this task as Declined.Feb 1 2021, 9:23 PM

Rollback to .27 has finished.

Cool thank you for the rollback. I will follow up on T271343 :]

hashar removed a subtask: T273249: MimeAnalyzer::improveTypeFromExtension() must be of the type string, null given.Feb 2 2021, 8:20 PM

Mahir256 mentioned this in T271589: Add lexeme language codes rkt, ctg.Feb 4 2021, 5:24 PM

brennen changed the task status from Declined to Resolved.Mar 11 2021, 7:10 PM

brennen moved this task from Doing to Done or Declined on the User-brennen board.

brennen changed the task status from Resolved to Declined.Mar 11 2021, 7:13 PM

1.36.0-wmf.28 deployment blockersClosed, DeclinedPublicReleaseActions