Page MenuHomePhabricator
Create Task
Maniphest T271364

[Regression wmf.23] Read, Edit, Edit Source, View History- these buttons are missing from the toolbar in the new Vector skin
Closed, ResolvedPublic
Actions

Description

Steps to replicate:

  1. On Beta cluster, enable Vector skin from Preferences>Appearances. (Leave the "Use Legacy Vector" option unchecked under the Skin Preferences section).
  1. Go to any page.

Observed Result:
Read, Edit, Edit Source, View History- these buttons are missing from the toolbar menu.

Screen Shot 2021-01-06 at 12.21.23 PM.png (502×2 px, 189 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/skins/Vectormaster+2 -2Fix template references
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Jan 6 2021, 8:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2021, 8:41 PM
Ryasmeen added a project: VisualEditor.Jan 6 2021, 8:43 PM
matmarex triaged this task as Unbreak Now! priority.Jan 6 2021, 9:31 PM
matmarex added a project: Vector (legacy skin).
RhinosF1 added a subscriber: RhinosF1.Jan 6 2021, 9:33 PM
matmarex added subscribers: Jdlrobson, phuedx.Jan 6 2021, 9:35 PM

I can reproduce locally, seems to be caused by https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/624909, which was a major change merged today. I haven't tried to debug why it causes this.

ppelberg added a comment.Jan 6 2021, 9:37 PM
In T271364#6726812, @matmarex wrote:

I can reproduce locally...

I can reproduce this as well.

Great spot, @Ryasmeen.

Jdlrobson claimed this task.EditedJan 6 2021, 9:57 PM
Jdlrobson lowered the priority of this task from Unbreak Now! to High.
Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).

Will take care of this either by a merge of reverting the patch or a follow up by end of day tomorrow. This patch should not be on the train yet, so dropping down to high (and will make sure this gets fixed ASAP).

This is another example of something that would have been easily avoided by T128864.

gerritbot added a comment.Jan 6 2021, 9:58 PM

Change 654683 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Fix template references

https://gerrit.wikimedia.org/r/654683

gerritbot added a project: Patch-For-Review.Jan 6 2021, 9:58 PM
gerritbot added a comment.Jan 6 2021, 10:42 PM

Change 654683 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix template references

https://gerrit.wikimedia.org/r/654683

Jdlrobson closed this task as Resolved.Jan 6 2021, 10:47 PM
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Thanks for reporting @Ryasmeen
This should be fixed now.

If you can see any further issues, please feel free to flag them on T268157 which is currently going through QA.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 6 2021, 10:49 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 6 2021, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 6 2021, 11:10 PM
Ryasmeen added a comment.Jan 7 2021, 12:11 AM

Thanks @Jdlrobson! Will use that task if I find any other issues.

Ryasmeen added a project: Verified.Jan 7 2021, 12:22 AM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL